Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#64419 closed defect (fixed)

Spaces in distname no longer work

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jmroot (Joshua Root)
Priority: Normal Milestone: MacPorts 2.7.2
Component: base Version: 2.7.1
Keywords: Cc:
Port:

Description

I assume MacPorts used to support values of distname containing spaces because the mandelbrot-set-viewer port was added having this line:

distname            Mandelbrot Set Viewer ${version}

The current version of MacPorts at that time was 2.3.1. MacPorts 2.7.1 however tries to fetch four separate distfiles ("Mandelbrot", "Set", "Viewer", and "5.01.zip").

https://build.macports.org/builders/jobs-mirror/builds/359583/steps/mirror/logs/stdio

--->  Attempting to fetch Mandelbrot from http://www.geometrian.com/data/programming/projects/Mandelbrot%20Set/Viewer%205.01/

Quoting it doesn't work either:

distname            "Mandelbrot Set Viewer ${version}"
$ port distf
--->  Distfiles for mandelbrot-set-viewer
Error: Failed to distfiles mandelbrot-set-viewer: list element in braces followed by ".zip" instead of space

I didn't find any other Portfiles using spaces in distname and I expect I'll work around this problem as I update this port to a newer version but base should support distfiles having spaces in their names.

Change History (5)

comment:1 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

In 3616fffd954cc488aef805725c6bdf385bcd0e8e/macports-ports (master):

mandelbrot-set-viewer: Update to 5.02

Use python 3.10. Update homepage and master_sites. Fix livecheck. Fix
fetch failure due to base bug with distfiles whose names contain spaces.

See: #64419

comment:2 Changed 2 years ago by jmroot (Joshua Root)

Owner: set to jmroot
Resolution: fixed
Status: newclosed

In 690fab10021ec6a5b11a1a659dc696d251b17bbc/macports-base (master):

Handle distname containing spaces

Fixes: #64419

comment:3 Changed 2 years ago by jmroot (Joshua Root)

A simpler workaround would be to set distfiles to "${distname}${extract.suffix}" directly.

comment:4 Changed 2 years ago by ryandesign (Ryan Carsten Schmidt)

In 0eeed9203bfc5b652df1321e3dcd12ae0ddb8a5d/macports-ports (master):

mandelbrot-set-viewer: Simplify distname workaround

See: #64419

comment:5 Changed 2 years ago by jmroot (Joshua Root)

Milestone: MacPorts 2.7.2
Note: See TracTickets for help on using tickets.