FLAC @1.3.4 fails to build on Leopard (both for ppc32 and ppc64)

[barracuda156]

libtool: compile:  /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I../.. -I../.. -I./include -I../../include -I/opt/local/include -D_FORTIFY_SOURCE=2 -DFLAC__USE_VISIBILITY_ATTR -faltivec -I/opt/local/include -pipe -Os -std=gnu89 -arch ppc64 -Wall -Wextra -Wstrict-prototypes -Wmissing-prototypes -Waggregate-return -Wcast-align -Wnested-externs -Wshadow -Wundef -Wmissing-declarations -Winline -Wdeclaration-after-statement -fvisibility=hidden -fgnu89-inline -msse2 -fstack-protector-strong -MT cpu.lo -MD -MP -MF .deps/cpu.Tpo -c cpu.c  -fno-common -DPIC -o .libs/cpu.o
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: unrecognized command line option "-fstack-protector-strong"
make[4]: *** [bitwriter.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [bitmath.lo] Error 1
make[4]: *** [bitreader.lo] Error 1
make[4]: *** [cpu.lo] Error 1
make[4]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4/src/libFLAC'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4/src/libFLAC'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4" && /usr/bin/make -j4 -w all OBJ_FORMAT=macho 
Exit code: 2
Error: Failed to build flac: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port flac failed

[barracuda156]

In fact it fails even for ppc:

libtool: compile:  /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I../.. -I../.. -I./include -I../../include -I/opt/local/include -D_FORTIFY_SOURCE=2 -DFLAC__USE_VISIBILITY_ATTR -faltivec -I/opt/local/include -pipe -Os -std=gnu89 -arch ppc -Wall -Wextra -Wstrict-prototypes -Wmissing-prototypes -Waggregate-return -Wcast-align -Wnested-externs -Wshadow -Wundef -Wmissing-declarations -Winline -Wdeclaration-after-statement -fvisibility=hidden -fgnu89-inline -msse2 -fstack-protector-strong -MT cpu.lo -MD -MP -MF .deps/cpu.Tpo -c cpu.c  -fno-common -DPIC -o .libs/cpu.o
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: unrecognized command line option "-fstack-protector-strong"
make[4]: *** [cpu.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [bitwriter.lo] Error 1
make[4]: *** [bitreader.lo] Error 1
make[4]: *** [bitmath.lo] Error 1
make[4]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4/src/libFLAC'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4/src/libFLAC'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/work/flac-1.3.4" && /usr/bin/make -j4 -w all OBJ_FORMAT=macho 
Exit code: 2
Error: Failed to build flac: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_audio_flac/flac/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there
is a bug.
Error: Processing of port flac failed

[ryandesign (Ryan Carsten Schmidt)]

config.log says:

configure:22275: checking if /usr/bin/gcc-4.2 supports stack smash protection
configure:22293: /usr/bin/gcc-4.2 -o conftest -fstack-protector-strong -I/opt/local/include -D_FORTIFY_SOURCE=2 -DFLAC__USE_VISIBILITY_ATTR -L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc conftest.c  >&5
cc1: error: unrecognized command line option "-fstack-protector-strong"
configure:22293: $? = 1
...
configure:22299: result: no

configure:22313: checking if /usr/bin/g++-4.2 supports stack smash protection
configure:22331: /usr/bin/g++-4.2 -o conftest -pipe -Os -arch ppc -Wall -Wextra -Wcast-align -Wshadow -Wwrite-strings -Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Wsign-promo -Wundef  -Weffc++ -fvisibility=hidden -I/opt/local/include -D_FORTIFY_SOURCE=2 -DFLAC__USE_VISIBILITY_ATTR -L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc conftest.cpp  >&5
conftest.cpp:45:1: warning: "__STDC_NO_VLA__" redefined
conftest.cpp:44:1: warning: this is the location of the previous definition
configure:22331: $? = 0
configure:22333: result: yes

main.log says:

:info:configure checking if /usr/bin/gcc-4.2 supports stack smash protection... no
:info:configure checking if /usr/bin/g++-4.2 supports stack smash protection... yes

:info:configure     Stack protector  : ........................ yes

So the build has decided to use the stack protector flag with your C compiler even though the configure script determined that your C compiler doesn't support it. This is clearly an upstream bug that should be reported to the flac developers for them to fix.

[barracuda156]

Replying to ryandesign:

So the build has decided to use the stack protector flag with your C compiler even though the configure script determined that your C compiler doesn't support it. This is clearly an upstream bug that should be reported to the flac developers for them to fix.

Thank you! I will do that.

UPD. Opened ticket here: ​https://github.com/xiph/flac/issues/303

[evanmiller (Evan Miller)]

In df975a3ac1e38defbe439c1ef0ad105d7d8406a5/macports-ports (master):

flac: disable -fstack-protector-strong with GCC 4.*

Closes: #64779

[evanmiller (Evan Miller)]

In a9a30ec3c1d773a86ff93a6503c97e915b822ed3/macports-ports (master):

flac: fix configure flag for disabling stack protection

See: #64779