py310-lz4: fatal error: 'lz4.h' file not found

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/ports-10.6_x86_64-builder/builds/99295/steps/install-port/logs/stdio

fatal error: 'lz4.h' file not found
#include <lz4.h>
         ^

Looks like -I/opt/local/include is missing in the compile line which suggests this build system is not using CPPFLAGS like it should. I also see -O3 in the compile line (whereas MacPorts optimization flags should be -Os by default) and I do not see any -arch flags (which should be there) suggesting this build system isn't using CFLAGS either.

[reneeotten (Renee Otten)]

In ec756621c0c1f621d50ef3cc822c878d730cc87a/macports-ports (master):

py-lz4: update to 4.0.0

Closes: #64969

[reneeotten (Renee Otten)]

Hhm... it still fails on 10.6 with the same error. Of course there is no strict requirement to support these old systems, but perhaps this can be fixed. The build uses pkgconfig to get the required include directories for liblz4 and such, and will not use -O3 if liblz4 is found. I verified that this all works correctly on 10.15 when I updated the port, but it appears not to work properly on 10.6.

I don't have a system with such an old OS, but if someone wants to try and help out please try to install the port sudo port install py310-lz4, which presumably will fail. Then please post the output of:

python3.10 -c "import pkgconfig; print(pkgconfig.exists('liblz4')) ; print(pkgconfig.libs('liblz4')) ; print(pkgconfig.cflags('liblz4'))"

[jmroot (Joshua Root)]

It's marked as noarch despite building extension modules. That can't be helping.

[jmroot (Joshua Root)]

In 1a1afef25aac6a26c2571fe52ac387a4da188433/macports-ports (master):

py-lz4: not noarch

See: #64969

[jmroot (Joshua Root)]

FTR, on 10.6:

% python3.10 -c "import pkgconfig; print(pkgconfig.exists('liblz4')) ; print(pkgconfig.libs('liblz4')) ; print(pkgconfig.cflags('liblz4'))"
True
-L/opt/local/lib -llz4
-I/opt/local/include

[reneeotten (Renee Otten)]

Replying to jmroot:

It's marked as noarch despite building extension modules. That can't be helping.

Ah, good point - I should have noticed that 😉. Ot seems to build fine now after you corrected this, thanks!