Opened 4 years ago

Closed 4 years ago

#65054 closed defect (fixed)

libgcc11 @11.3.0 fails to patch on i386

Reported by: jmroot (Joshua Root) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cjones051073 (Chris Jones)
Port: gcc11

Description

​https://build.macports.org/builders/ports-10.6_i386-builder/builds/67162/steps/install-port/logs/stdio

Change History (7)

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Copying the error message into the ticket in case the buildbot log disappears: 

--->  Applying patches to libgcc11
--->  Applying patch-iains-i686-clang-bootstrap.diff
DEBUG: Environment: 
CC_PRINT_OPTIONS='YES'
CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_gcc11/libgcc11/work/.CC_PRINT_OPTIONS'
CPATH='/opt/local/include'
DEVELOPER_DIR='/Developer'
LIBRARY_PATH='/opt/local/lib'
MACOSX_DEPLOYMENT_TARGET='10.6'
Executing:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_gcc11/libgcc11/work/gcc-11.3.0" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/gcc11/files/patch-iains-i686-clang-bootstrap.diff'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_gcc11/libgcc11/work/gcc-11.3.0" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/gcc11/files/patch-iains-i686-clang-bootstrap.diff'
patching file Makefile.in
Hunk #1 succeeded at 653 (offset 3 lines).
patching file config/mh-darwin
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file config/mh-darwin.rej
patching file gcc/configure
Hunk #1 succeeded at 32397 (offset 1297 lines).
Hunk #2 succeeded at 32425 (offset 1297 lines).
patching file gcc/configure.ac
Hunk #1 succeeded at 7628 (offset 626 lines).
Hunk #2 succeeded at 7642 (offset 626 lines).
Command failed:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_gcc11/libgcc11/work/gcc-11.3.0" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/gcc11/files/patch-iains-i686-clang-bootstrap.diff'
Exit code: 1

comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

which says:

it is expected that the proper fix will be back ported to GCC-11 (for 11.3) and 10 (for 10.4).

so that should mean we can remove the patch.

comment:4 Changed 4 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added

comment:5 in reply to:  3 Changed 4 years ago by mascguy (Christopher Nielsen)

Replying to ryandesign:

which says:

it is expected that the proper fix will be back ported to GCC-11 (for 11.3) and 10 (for 10.4).

so that should mean we can remove the patch.

Assuming that's all that's needed, I'll take care of this too. (Albeit again via a PR.)

comment:6 Changed 4 years ago by mascguy (Christopher Nielsen)

Cc: mascguy removed
Owner: set to mascguy
Status: new → assigned

comment:7 Changed 4 years ago by Christopher Nielsen <mascguy@…>

Resolution: → fixed
Status: assigned → closed

In 4a321f1e85cca44954ffbe51a876489cd0d491fa/macports-ports (master):

gcc11: remove obsolete patch for i386 bootstrap
Fixes: #65054

Note: See TracTickets for help on using tickets.