#65405 closed enhancement (fixed)

Frotz @2.5.3: Add option for sound and sdl interface

Reported by: mbrethen Owned by: jmroot (Joshua Root)
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: haspatch Cc:
Port: frotz

Description (last modified by mbrethen)

Attached Portfile.diff adds variants "snd" and "sdl" and also archives docs in ${prefix}/share/doc/${name}. Note: the Makefile.diff has also been updated to remove a hardcoded ${prefix}.

Attachments (3)

patch-Makefile (609 bytes) - added by mbrethen 21 months ago.
patch Makefile to use ${prefix} instead of hardcoded path
Portfile.diff (2.7 KB) - added by mbrethen 21 months ago.
Portfile patch
Portfile (1.5 KB) - added by mbrethen 21 months ago.

Download all attachments as: .zip

Change History (7)

Changed 21 months ago by mbrethen

Attachment: patch-Makefile added

patch Makefile to use ${prefix} instead of hardcoded path

comment:1 Changed 21 months ago by ryandesign (Ryan Carsten Schmidt)

Your patch also totally reformats the whitespace of the Portfile, making it difficult to see what functional changes you're proposing. Usually whitespace changes should be made in a separate commit from functional changes.

Changed 21 months ago by mbrethen

Attachment: Portfile.diff added

Portfile patch

comment:2 in reply to:  1 Changed 21 months ago by mbrethen

Replying to ryandesign:

Your patch also totally reformats the whitespace of the Portfile, making it difficult to see what functional changes you're proposing. Usually whitespace changes should be made in a separate commit from functional changes.

Re-uploaded diff--lmk if that's acceptable.

Changed 21 months ago by mbrethen

Attachment: Portfile added

comment:3 Changed 21 months ago by mbrethen

Description: modified (diff)

comment:4 Changed 18 months ago by jmroot (Joshua Root)

Owner: set to jmroot
Resolution: fixed
Status: newclosed

In 496e5b91e3b6c9dc6820d77ab60dbe400d1924ee/macports-ports (master):

frotz: update to 2.54, add SDL and sound

Closes: #65405

Note: See TracTickets for help on using tickets.