isl @0.25: builds failing for 10.7 and 10.13; needs fixes for c++17 detection

[dyne2meter]

:info:build ar cru libdep.a dep.o 
:info:build /opt/local/bin/ranlib: file: libdep.a(dep.o) has no symbols
:info:build ranlib libdep.a
:info:build ranlib: file: libdep.a(dep.o) has no symbols
:info:build warning: ranlib: warning for library: libdep.a the table of contents is empty (no object file members in the library define global symbols)
:info:build /bin/sh ./libtool  --tag=CC   --mode=link /usr/bin/clang -Wall  -pipe -Os -arch x86_64 -version-info 25:0:2  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -o libisl.la -rpath /opt/local/lib  isl_gmp.lo isl_val_gmp.lo isl_aff.lo isl_aff_map.lo isl_affine_hull.lo isl_arg.lo isl_ast.lo isl_ast_build.lo isl_ast_build_expr.lo isl_ast_codegen.lo isl_ast_graft.lo basis_reduction_tab.lo isl_bernstein.lo isl_blk.lo isl_bound.lo isl_box.lo isl_coalesce.lo isl_constraint.lo isl_convex_hull.lo isl_ctx.lo isl_deprecated.lo isl_dim_map.lo isl_equalities.lo isl_factorization.lo isl_farkas.lo isl_ffs.lo isl_flow.lo isl_fold.lo isl_hash.lo isl_id_to_ast_expr.lo isl_id_to_id.lo isl_id_to_pw_aff.lo isl_ilp.lo isl_input.lo isl_local.lo isl_local_space.lo isl_lp.lo isl_map.lo isl_map_list.lo isl_map_simplify.lo isl_map_subtract.lo isl_map_to_basic_set.lo isl_mat.lo isl_morph.lo isl_id.lo isl_obj.lo isl_options.lo isl_output.lo isl_point.lo isl_polynomial.lo isl_printer.lo print.lo isl_range.lo isl_reordering.lo isl_sample.lo isl_scan.lo isl_schedule.lo isl_schedule_band.lo isl_schedule_node.lo isl_schedule_read.lo isl_schedule_tree.lo isl_schedule_constraints.lo isl_scheduler.lo isl_scheduler_clustering.lo isl_set_list.lo isl_sort.lo isl_space.lo isl_stream.lo isl_seq.lo isl_set_to_ast_graft_list.lo isl_stride.lo isl_tab.lo isl_tab_pip.lo isl_tarjan.lo isl_transitive_closure.lo isl_union_map.lo isl_val.lo isl_vec.lo isl_version.lo isl_vertices.lo -lgmp 
:info:build libtool: link: /usr/bin/clang -dynamiclib -Wl,-undefined -Wl,dynamic_lookup -o .libs/libisl.23.dylib  .libs/isl_gmp.o .libs/isl_val_gmp.o .libs/isl_aff.o .libs/isl_aff_map.o .libs/isl_affine_hull.o .libs/isl_arg.o .libs/isl_ast.o .libs/isl_ast_build.o .libs/isl_ast_build_expr.o .libs/isl_ast_codegen.o .libs/isl_ast_graft.o .libs/basis_reduction_tab.o .libs/isl_bernstein.o .libs/isl_blk.o .libs/isl_bound.o .libs/isl_box.o .libs/isl_coalesce.o .libs/isl_constraint.o .libs/isl_convex_hull.o .libs/isl_ctx.o .libs/isl_deprecated.o .libs/isl_dim_map.o .libs/isl_equalities.o .libs/isl_factorization.o .libs/isl_farkas.o .libs/isl_ffs.o .libs/isl_flow.o .libs/isl_fold.o .libs/isl_hash.o .libs/isl_id_to_ast_expr.o .libs/isl_id_to_id.o .libs/isl_id_to_pw_aff.o .libs/isl_ilp.o .libs/isl_input.o .libs/isl_local.o .libs/isl_local_space.o .libs/isl_lp.o .libs/isl_map.o .libs/isl_map_list.o .libs/isl_map_simplify.o .libs/isl_map_subtract.o .libs/isl_map_to_basic_set.o .libs/isl_mat.o .libs/isl_morph.o .libs/isl_id.o .libs/isl_obj.o .libs/isl_options.o .libs/isl_output.o .libs/isl_point.o .libs/isl_polynomial.o .libs/isl_printer.o .libs/print.o .libs/isl_range.o .libs/isl_reordering.o .libs/isl_sample.o .libs/isl_scan.o .libs/isl_schedule.o .libs/isl_schedule_band.o .libs/isl_schedule_node.o .libs/isl_schedule_read.o .libs/isl_schedule_tree.o .libs/isl_schedule_constraints.o .libs/isl_scheduler.o .libs/isl_scheduler_clustering.o .libs/isl_set_list.o .libs/isl_sort.o .libs/isl_space.o .libs/isl_stream.o .libs/isl_seq.o .libs/isl_set_to_ast_graft_list.o .libs/isl_stride.o .libs/isl_tab.o .libs/isl_tab_pip.o .libs/isl_tarjan.o .libs/isl_transitive_closure.o .libs/isl_union_map.o .libs/isl_val.o .libs/isl_vec.o .libs/isl_version.o .libs/isl_vertices.o   -L/opt/local/lib -lgmp  -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64   -install_name  /opt/local/lib/libisl.23.dylib -compatibility_version 26 -current_version 26.0 -Wl,-single_module
:info:build libtool: link: (cd ".libs" && rm -f "libisl.dylib" && ln -s "libisl.23.dylib" "libisl.dylib")
:info:build libtool: link: ar cr .libs/libisl.a  isl_gmp.o isl_val_gmp.o isl_aff.o isl_aff_map.o isl_affine_hull.o isl_arg.o isl_ast.o isl_ast_build.o isl_ast_build_expr.o isl_ast_codegen.o isl_ast_graft.o basis_reduction_tab.o isl_bernstein.o isl_blk.o isl_bound.o isl_box.o isl_coalesce.o isl_constraint.o isl_convex_hull.o isl_ctx.o isl_deprecated.o isl_dim_map.o isl_equalities.o isl_factorization.o isl_farkas.o isl_ffs.o isl_flow.o isl_fold.o isl_hash.o isl_id_to_ast_expr.o isl_id_to_id.o isl_id_to_pw_aff.o isl_ilp.o isl_input.o isl_local.o isl_local_space.o isl_lp.o isl_map.o isl_map_list.o isl_map_simplify.o isl_map_subtract.o isl_map_to_basic_set.o isl_mat.o isl_morph.o isl_id.o isl_obj.o isl_options.o isl_output.o isl_point.o isl_polynomial.o isl_printer.o print.o isl_range.o isl_reordering.o isl_sample.o isl_scan.o isl_schedule.o isl_schedule_band.o isl_schedule_node.o isl_schedule_read.o isl_schedule_tree.o isl_schedule_constraints.o isl_scheduler.o isl_scheduler_clustering.o isl_set_list.o isl_sort.o isl_space.o isl_stream.o isl_seq.o isl_set_to_ast_graft_list.o isl_stride.o isl_tab.o isl_tab_pip.o isl_tarjan.o isl_transitive_closure.o isl_union_map.o isl_val.o isl_vec.o isl_version.o isl_vertices.o
:info:build /opt/local/bin/ranlib: file: .libs/libisl.a(isl_ffs.o) has no symbols
:info:build libtool: link: ranlib .libs/libisl.a
:info:build In file included from isl_test_cpp17-checked.cc:23:
:info:build ./isl_test_cpp17-generic.cc:48:16: error: call to unavailable member function 'value': introduced in macOS 10.14
:info:build         if (maybe_int.value() != 5)
:info:build             ~~~~~~~~~~^~~~~
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:942:27: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type& value() &
:info:build                           ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:933:33: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type const& value() const&
:info:build                                 ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:951:28: note: candidate function not viable: no known conversion from 'optional<...>' to 'optional<...>' for object argument
:info:build     constexpr value_type&& value() &&
:info:build                            ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:960:34: note: candidate function not viable: no known conversion from 'optional<...>' to 'const optional<...>' for object argument
:info:build     constexpr value_type const&& value() const&&
:info:build                                  ^
:info:build In file included from isl_test_cpp17-checked.cc:23:
:info:build ./isl_test_cpp17-generic.cc:63:15: error: call to unavailable member function 'value': introduced in macOS 10.14
:info:build                 if (maybe_s.value()->freed != &freed)
:info:build                     ~~~~~~~~^~~~~
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:942:27: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type& value() &
:info:build                           ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:933:33: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type const& value() const&
:info:build                                 ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:951:28: note: candidate function not viable: no known conversion from 'optional<...>' to 'optional<...>' for object argument
:info:build     constexpr value_type&& value() &&
:info:build                            ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:960:34: note: candidate function not viable: no known conversion from 'optional<...>' to 'const optional<...>' for object argument
:info:build     constexpr value_type const&& value() const&&
:info:build                                  ^
:info:build ranlib: file: .libs/libisl.a(isl_ffs.o) has no symbols
:info:build libtool: link: ( cd ".libs" && rm -f "libisl.la" && ln -s "../libisl.la" "libisl.la" )
:info:build /bin/sh ./libtool  --tag=CC   --mode=link /usr/bin/clang -Wall  -pipe -Os -arch x86_64  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -o isl_test isl_test.o libisl.la -lgmp 
:info:build /bin/sh ./libtool  --tag=CC   --mode=link /usr/bin/clang -Wall  -pipe -Os -arch x86_64  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -o isl_pip pip.o libisl.la -lgmp 
:info:build /bin/sh ./libtool  --tag=CC   --mode=link /usr/bin/clang -Wall  -pipe -Os -arch x86_64  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -o isl_polyhedron_sample polyhedron_sample.o libisl.la 
:info:build /bin/sh ./libtool  --tag=CC   --mode=link /usr/bin/clang -Wall  -pipe -Os -arch x86_64  -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -o isl_polyhedron_minimize polyhedron_minimize.o libisl.la -lgmp 
:info:build 2 errors generated.
:info:build make[2]: *** [isl_test_cpp17-checked.o] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....
:info:build In file included from isl_test_cpp17.cc:20:
:info:build ./isl_test_cpp17-generic.cc:48:16: error: call to unavailable member function 'value': introduced in macOS 10.14
:info:build         if (maybe_int.value() != 5)
:info:build             ~~~~~~~~~~^~~~~
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:942:27: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type& value() &
:info:build                           ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:933:33: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type const& value() const&
:info:build                                 ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:951:28: note: candidate function not viable: no known conversion from 'optional<...>' to 'optional<...>' for object argument
:info:build     constexpr value_type&& value() &&
:info:build                            ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:960:34: note: candidate function not viable: no known conversion from 'optional<...>' to 'const optional<...>' for object argument
:info:build     constexpr value_type const&& value() const&&
:info:build                                  ^
:info:build In file included from isl_test_cpp17.cc:20:
:info:build ./isl_test_cpp17-generic.cc:63:15: error: call to unavailable member function 'value': introduced in macOS 10.14
:info:build                 if (maybe_s.value()->freed != &freed)
:info:build                     ~~~~~~~~^~~~~
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:942:27: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type& value() &
:info:build                           ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:933:33: note: candidate function has been explicitly made unavailable
:info:build     constexpr value_type const& value() const&
:info:build                                 ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:951:28: note: candidate function not viable: no known conversion from 'optional<...>' to 'optional<...>' for object argument
:info:build     constexpr value_type&& value() &&
:info:build                            ^
:info:build /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:960:34: note: candidate function not viable: no known conversion from 'optional<...>' to 'const optional<...>' for object argument
:info:build     constexpr value_type const&& value() const&&
:info:build                                  ^
:info:build libtool: link: /usr/bin/clang -Wall -pipe -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -o .libs/isl_test isl_test.o  -L/opt/local/lib ./.libs/libisl.dylib -lgmp
:info:build libtool: link: /usr/bin/clang -Wall -pipe -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -o .libs/isl_pip pip.o  -L/opt/local/lib ./.libs/libisl.dylib -lgmp
:info:build libtool: link: /usr/bin/clang -Wall -pipe -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -o .libs/isl_polyhedron_minimize polyhedron_minimize.o  -L/opt/local/lib ./.libs/libisl.dylib -lgmp
:info:build libtool: link: /usr/bin/clang -Wall -pipe -Os -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -o .libs/isl_polyhedron_sample polyhedron_sample.o  -L/opt/local/lib ./.libs/libisl.dylib -lgmp
:info:build 2 errors generated.
:info:build make[2]: *** [isl_test_cpp17.o] Error 1
:info:build mv -f .deps/isl_test_cpp-isl_test_cpp.Tpo .deps/isl_test_cpp-isl_test_cpp.Po
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_isl/isl/work/isl-0.25'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_isl/isl/work/isl-0.25'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_isl/isl/work/isl-0.25'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_isl/isl/work/isl-0.25" && /usr/bin/make -j8 -w all 
:info:build Exit code: 2
:error:build Failed to build isl: command execution failed
:debug:build Error code: CHILDSTATUS 3884 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$callback {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec -callback portprogress::target_progress_callback build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_isl/isl/main.log for details.

[dyne2meter]

main.log

[mascguy (Christopher Nielsen)]

Builds also failing for 10.7, albeit with a different issue:

libtool: link: /opt/local/bin/clang++-mp-14 -std=c++11 -std=gnu++17 -pipe -Os -stdlib=libc++ -arch x86_64 -Wl,-headerpad_max_install_names -arch x86_64 -o .libs/isl_test_cpp17-checked isl_test_cpp17-checked.o  -L/opt/local/lib ./.libs/libisl.dylib /opt/local/lib/libgmp.dylib
Undefined symbols for architecture x86_64:
  "std::bad_optional_access::~bad_optional_access()", referenced from:
      std::__1::__throw_bad_optional_access() in isl_test_cpp17-checked.o
  "typeinfo for std::bad_optional_access", referenced from:
      std::__1::__throw_bad_optional_access() in isl_test_cpp17-checked.o
  "vtable for std::bad_optional_access", referenced from:
      std::__1::__throw_bad_optional_access() in isl_test_cpp17-checked.o
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [isl_test_cpp17-checked] Error 1

For 10.13, the issue can potentially be solved by expanding the Clang blacklist. But that won't help for 10.7, since we're already using mp-clang-14 there.

Thoughts relative to the best approach to fixing this...?

[mascguy (Christopher Nielsen)]

Of note, we're seeing a different issue on the 10.13 buildbot. Since the reporter is building with Xcode 10.1 - while the buildbot is using 9.4.1 - that presumably explains it:

In file included from isl_test2.cc:12:
./include/isl/cpp.h:22:10: fatal error: 'any' file not found
#include <any>
         ^~~~~
[...]
In file included from isl_test_cpp17.cc:7:
./include/isl/cpp.h:22:10: fatal error: 'any' file not found
#include <any>
         ^~~~~
[...]
In file included from ./include/isl/typed_cpp.h:13:
./include/isl/cpp.h:22:10: fatal error: 'any' file not found
#include <any>
         ^~~~~
[...]
In file included from isl_test_cpp17-checked.cc:7:
./include/isl/cpp-checked.h:21:10: fatal error: 'any' file not found
#include <any>
         ^~~~~

[kencu (Ken)]

in both cases, it appears that the tests that isl is using to see if certain c++ standards are available during configure are not complete enough to detect when certain c++17 features are not actually available in the end on 10.7 or 10.13.

System libc++ versions implemented c++17 gradually, and full support only comes in at 10.15 I believe. Before that you have partial support.

You'll have to dig in on why 10.8 builds but 10.7 doesn't, but I would guess 10.8 uses the system compiler which tests as having no c++17 support, whereas 10.7 uses clang-14 which seems to support c++17, but in the end, the overall system does not support it well enough and the link fails.

My guess is turning off c++17 manually by some mechanism on systems before - 10.14? - is probably going to be needed.

[kencu (Ken)]

or fixing the c++ tests to be more robust. That is for sure better, if someone has the chops to do it.

A small step in fixing the tests was already added last version I note. Maybe it is possible, with appropriate time and talent, to fix the tests.

[mascguy (Christopher Nielsen)]

Marcus, since I merged the PR for this update, I'm happy to take on fixing. Could use some guidance though, relative to the best approach.

[mascguy (Christopher Nielsen)]

Replying to kencu:

in both cases, it appears that the tests that isl is using to see if certain c++ standards are available during configure are not complete enough to detect when certain c++17 features are not actually available in the end on 10.7 or 10.13.

System libc++ versions implemented c++17 gradually, and full support only comes in at 10.15 I believe. Before that you have partial support.

You'll have to dig in on why 10.8 builds but 10.7 doesn't, but I would guess 10.8 uses the system compiler which tests as having no c++17 support, whereas 10.7 uses clang-14 which seems to support c++17, but in the end, the overall system does not support it well enough and the link fails.

My guess is turning off c++17 manually by some mechanism on systems before - 10.14? - is probably going to be needed.

Ah, makes sense Ken, I'll take a closer look at all of this. Thanks for the thoughts/guidance, as always!

[mascguy (Christopher Nielsen)]

Also see duplicate issue:65539

[Christopher Nielsen <mascguy@…>]

In aa4c9c97e3afbfc012af15af8e4c800e47275ea2/macports-ports (master):

isl: revert update to 0.25, until working across-the-board

• Builds failing for 10.13 and 10.7, and fallout is huge

See: ​https://github.com/macports/macports-ports/pull/15391
See: #65532

[mascguy (Christopher Nielsen)]

Now that we've reverted the update, I'll let Marcus tackle when he's ready to update the port.

[barracuda156]

You'll have to dig in on why 10.8 builds but 10.7 doesn't, but I would guess 10.8 uses the system compiler which tests as having no c++17 support, whereas 10.7 uses clang-14 which seems to support c++17, but in the end, the overall system does not support it well enough and the link fails.

It also builds fine on 10.6.

[kencu (Ken)]

on 10.6, we install a much newer libc++, so perhaps paradoxically, it is a much more capable system in some ways than “newer” systems

[cjones051073 (Chris Jones)]

Replying to kencu:

on 10.6, we install a much newer libc++, so perhaps paradoxically, it is a much more capable system in some ways than “newer” systems

maybe its time to start thinking about doing this on newer systems by default ? c++17 isn't going anywhere and soon it could start to really impact things on macOS10.13(4?) and older...

[kencu (Ken)]

I installed our libcxx port on 10.7, replacing the system’s libc++.

Lots of things worked great, but for some reason iCal was crashy with that setup… so I came up with macports-libcxx instead, which is also not perfect but leaves the system alone.

Perhaps the iCal thing is fixable… or perhaps there will be other similar hiccups found in the wild….

[barracuda156]

How about we restore isl-devel to have 0.25 there?

[barracuda156]

On 10.5.8 isl 0.25 builds fine as +universal:

36-249:~ svacchanda$ port -v installed isl
The following ports are currently installed:
  isl @0.22.1_0 requested_variants='-universal' platform='darwin 9' archs='ppc' date='2021-12-22T12:17:44+0800'
  isl @0.22.1_0+universal requested_variants='+universal' platform='darwin 9' archs='ppc ppc64' date='2021-12-21T10:37:51+0800'
  isl @0.24_1+universal requested_variants='+universal' platform='darwin 9' archs='ppc ppc64' date='2021-12-29T00:57:53+0800'
  isl @0.25_0+universal (active) requested_variants='+universal' platform='darwin 9' archs='ppc ppc64' date='2022-10-07T16:33:48+0800'