Opened 4 months ago

Last modified 4 months ago

#65670 new defect

minivmac-devel @37.03: reinplace didn't change anything

Reported by: mbrethen Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.7.2
Keywords: has-patch Cc: ryandesign (Ryan Schmidt)
Port: minivmac

Description

ports $ sudo port install minivmac-custom-devel
Password:
Warning: port definitions are more than two weeks old, consider updating them by running 'port selfupdate'.
--->  Computing dependencies for minivmac-custom-devel
--->  Fetching distfiles for minivmac-custom-devel
--->  Attempting to fetch minivmac-37.03.src.tgz from https://distfiles.macports.org/minivmac
--->  Attempting to fetch icnsosx-1.0.0.zip from https://distfiles.macports.org/minivmac
--->  Verifying checksums for minivmac-custom-devel
--->  Extracting minivmac-custom-devel
--->  Configuring minivmac-custom-devel
Warning: reinplace s|gcc|/usr/bin/clang|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/512x342/Makefile
Warning: reinplace s|-mmacosx-version-min=[0-9.]+||g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/512x342/Makefile
Warning: reinplace s|gcc|/usr/bin/clang|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/II 4-bit 704x450/Makefile
Warning: reinplace s|-mmacosx-version-min=[0-9.]+||g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/II 4-bit 704x450/Makefile
Warning: reinplace s|gcc|/usr/bin/clang|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/II 8-bit 704x450/Makefile
Warning: reinplace s|-mmacosx-version-min=[0-9.]+||g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/II 8-bit 704x450/Makefile

I made a patch to correct the reinplace statements based on the source Makefile.

Attachments (1)

patch-portfile.diff (1.1 KB) - added by mbrethen 4 months ago.

Download all attachments as: .zip

Change History (4)

Changed 4 months ago by mbrethen

Attachment: patch-portfile.diff added

comment:1 Changed 4 months ago by ryandesign (Ryan Schmidt)

The current Portfile code is probably correct on some systems but not others; after your patch, it will be correct on different systems and incorrect on different systems. I'd like to find a solution that is correct on all systems.

comment:2 Changed 4 months ago by mbrethen

The other warning was clipped somehow when I created the ticket:

Warning: reinplace s|-mmacosx-version-min=[0-9.]+||g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_minivmac-devel/minivmac-custom-devel/work/build/x86_64/II 4-bit 704x450/Makefile

After the patch it errored on use of '-target' so I included it in the patch with '-arch'.

Last edited 4 months ago by mbrethen (previous) (diff)

comment:3 Changed 4 months ago by ryandesign (Ryan Schmidt)

Certainly the parts of your patch that mention x86_64 are not going to be correct when the port is building for architectures other than x86_64.

I think the problems stem from the fact that the Portfile tells the Mini vMac build system what version of Xcode is installed. This in turn causes the Mini vMac build system to vary what it puts into the Makefile. Most of the differences are probably not things we want in MacPorts and are things that the reinplaces in the Portfile were trying to eliminate. Probably the Portfile should not tell the build system the Xcode version anymore. Possibly it should even tell the build system to generate generic Makefiles, not related to Xcode. We may then need to patch in the flags MacPorts wants it to use but at least then it can be done once and be correct everywhere. It has been years since I have worked on this but that is what I recall from previous investigation.

Note: See TracTickets for help on using tickets.