libsdl: dylib compatibility version changed from 12 to 1, breaking existing binaries

[catap (Kirill A. Korinsky)]

Seems that update of libsdl at [ddff16416716aaf2a1c522f7f94301e9f4df6496/macports-ports] had broken a lot of ports.

For example on macOS 12:

sudo port install --unrequested smpeg
--->  Computing dependencies for smpeg
The following dependencies will be installed: 
 libsdl
 sdl12-compat
Continue? [Y/n]: y
--->  Fetching archive for sdl12-compat
--->  Attempting to fetch sdl12-compat-1.2.52_1.darwin_21.x86_64.tbz2 from https://packages.macports.org/sdl12-compat
--->  Attempting to fetch sdl12-compat-1.2.52_1.darwin_21.x86_64.tbz2.rmd160 from https://packages.macports.org/sdl12-compat
--->  Installing sdl12-compat @1.2.52_1
--->  Activating sdl12-compat @1.2.52_1
--->  Cleaning sdl12-compat
--->  Fetching archive for libsdl
--->  Attempting to fetch libsdl-1.2.15-20220801_1+compat.darwin_21.x86_64.tbz2 from https://packages.macports.org/libsdl
--->  Attempting to fetch libsdl-1.2.15-20220801_1+compat.darwin_21.x86_64.tbz2.rmd160 from https://packages.macports.org/libsdl
--->  Installing libsdl @1.2.15-20220801_1+compat
--->  Activating libsdl @1.2.15-20220801_1+compat
--->  Cleaning libsdl
--->  Fetching archive for smpeg
--->  Attempting to fetch smpeg-0.4.4_9.darwin_21.x86_64.tbz2 from https://packages.macports.org/smpeg
--->  Attempting to fetch smpeg-0.4.4_9.darwin_21.x86_64.tbz2.rmd160 from https://packages.macports.org/smpeg
--->  Installing smpeg @0.4.4_9
--->  Activating smpeg @0.4.4_9
--->  Cleaning smpeg
--->  Scanning binaries for linking errors
--->  Found 2 broken files, matching files to ports      
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: smpeg @0.4.4
Continue? [Y/n]: 

The same issue happens with libsdl_sound, libsdl_image and looks like that each prebuilt port which depends on libsdl

[mascguy (Christopher Nielsen)]

Yep, I'm seeing the same types of things locally, with buildbot binaries like libsdl_gfx:

$ sudo port -v rev-upgrade
--->  Scanning binaries for linking errors
Incompatible library version: /opt/local/lib/libSDL_gfx.14.dylib requires version 12.0.0 or later, but /opt/local/lib/libSDL-1.2.0.dylib provides version 1.0.0
--->  Found 1 broken file, matching files to ports
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: libsdl_gfx @2.0.24

[catap (Kirill A. Korinsky)]

Christopher, and libsdl_ttf is broken and rev-upgrade can't fix it :)

[jmroot (Joshua Root)]

So, fun fact, dyld apparently doesn't check this stuff any more on macOS 12. There's no runtime error for an incompatible compatibility_version.

[jmroot (Joshua Root)]

The major version and the current_version didn't change, BTW.

[jmroot (Joshua Root)]

In 0843dc45c69fe0da151dce607f048144087a345e/macports-ports (master):

sdl12-compat: fix lib compatibility_version

Also adopt alternative SDL_stdinc.h that was accepted upstream.

Fixes: #65768

[mascguy (Christopher Nielsen)]

Replying to jmroot:

sdl12-compat: fix lib compatibility_version

Ah, for some reason I was thinking it was major_version, but didn't consider compatibility_version. Still learning...