asymptote @2.70_3: fails to patch on macOS 13.0

[mcmara (Jack McMara)]

First of all, a simple install hangs on applying patches:

$ sudo port install asymptote
--->  Computing dependencies for asymptote
--->  Fetching archive for asymptote
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/asymptote
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://mse.uk.packages.macports.org/asymptote
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ema.uk.packages.macports.org/asymptote
--->  Fetching distfiles for asymptote
--->  Verifying checksums for asymptote
--->  Extracting asymptote
--->  Applying patches to asymptote

Adding more verbosity shows the problem:

$ sudo port -v install asymptote
--->  Computing dependencies for asymptote.
--->  Fetching archive for asymptote
--->  asymptote-2.70_3.darwin_22.x86_64.tbz2 doesn't seem to exist in /opt/local/var/macports/incoming/verified
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://mse.uk.packages.macports.org/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   196    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ema.uk.packages.macports.org/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   315    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Applying patches to asymptote
--->  Applying patch-Makefile.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/asymptote/files/patch-Makefile.diff'
patching file Makefile.in

The patch command above is somehow failing and silently waiting for use input. In fact:

$ cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/asymptote/files/patch-Makefile.diff'
patching file Makefile.in
Reversed (or previously applied) patch detected!  Assume -R? [y] 

Hitting enter terminates in an error:

$ sudo port -v install asymptote
--->  Computing dependencies for asymptote.
--->  Fetching archive for asymptote
--->  asymptote-2.70_3.darwin_22.x86_64.tbz2 doesn't seem to exist in /opt/local/var/macports/incoming/verified
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://mse.uk.packages.macports.org/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   196    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ema.uk.packages.macports.org/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   315    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Applying patches to asymptote
--->  Applying patch-Makefile.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/asymptote/files/patch-Makefile.diff'
patching file Makefile.in



Reversed (or previously applied) patch detected!  Assume -R? [y] File to patch: No file found--skip this patch? [y] 1 out of 1 hunks ignored--saving rejects to Oops.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/asymptote/files/patch-Makefile.diff'
Exit code: 1
Error: Failed to patch asymptote: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port asymptote failed

[ryandesign (Ryan Carsten Schmidt)]

Replying to mcmara:

Reversed (or previously applied) patch detected!  Assume -R? [y] 

This is happening because you are trying to apply a patch that has already been applied.

Please sudo port clean asymptote and try again. When it fails again, that will show us what the original failure was.

The problem may be that the patch has fuzz:

patching file Makefile.in
Hunk #1 succeeded at 10 with fuzz 1.
Hunk #2 succeeded at 138 with fuzz 2 (offset 1 line).

Another recent ticket on Ventura about a different port suggested that the patch utility on Ventura is no longer willing to apply patches with fuzz. If your log confirms that's the problem, the patch should be regenerated.

[mcmara (Jack McMara)]

Yes: cleaning the port pulled up the original problem. Sorry for that. Here it is the output (the empty lines below is where I had to hit enter to allow the process to respond to the hidden response request):

$ sudo port clean asymptote 
--->  Cleaning asymptote

$ sudo port -v install asymptote 
--->  Computing dependencies for asymptote.
--->  Fetching archive for asymptote
--->  asymptote-2.70_3.darwin_22.x86_64.tbz2 doesn't seem to exist in /opt/local/var/macports/incoming/verified
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ywg.ca.packages.macports.org/mirror/macports/packages/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://mse.uk.packages.macports.org/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   196    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Attempting to fetch asymptote-2.70_3.darwin_22.x86_64.tbz2 from https://ema.uk.packages.macports.org/asymptote
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   315    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
--->  Fetching distfiles for asymptote
--->  Verifying checksums for asymptote
--->  Checksumming asymptote-2.70.src.tgz
--->  Extracting asymptote
--->  Extracting asymptote-2.70.src.tgz
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work" && /usr/bin/gzip -dc '/opt/local/var/macports/distfiles/asymptote/asymptote-2.70.src.tgz' | /usr/bin/tar -xf - 
--->  Applying patches to asymptote
--->  Applying patch-Makefile.diff
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/asymptote/files/patch-Makefile.diff'
patching file Makefile.in


File to patch: No file found--skip this patch? [y] 1 out of 1 hunks ignored--saving rejects to Oops.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/graphics/asymptote/files/patch-Makefile.diff'
Exit code: 1
Error: Failed to patch asymptote: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port asymptote failed

[kencu (Ken)]

the output from the patch command is initially not being displayed, it seems. As above, the terminal just waits after the patch command .. and then you push enter twice and you see what the issue probably was.

[kencu (Ken)]

updated patch

[kencu (Ken)]

but doesn't fix it:

make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70/doc'
../asy -dir ../base -config "" -render=0 -h 2>&1 | grep -iv Asymptote > options
../asy -dir ../base -config "" -render=0 -f pdf -noprc Bode.asy
../asy -dir ../base -config "" -render=0 -f pdf -noprc CAD1.asy
../asy -dir ../base -config "" -render=0 -f pdf -noprc CDlabel.asy
../asy -dir ../base -config "" -render=0 -f pdf -noprc GaussianSurface.asy
../asy -dir ../base -config "" -render=0 -f pdf -noprc HermiteSpline.asy
../asy -dir ../base -config "" -render=0 -f pdf -noprc Hobbycontrol.asy
../asy -dir ../base -config "" -render=0 -f pdf -noprc Hobbydir.asy
ls base/*.asy | grep -v plain\* | \
          grep -v three_\* | grep -v featpost3D | xargs ./asy -dir base -config "" -render=0 -l >> asy.list
make[1]: *** [Hobbycontrol.pdf] Abort trap: 6
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [CAD1.pdf] Abort trap: 6
make[1]: *** [Hobbydir.pdf] Abort trap: 6
make[1]: *** [CDlabel.pdf] Abort trap: 6
make[1]: *** [HermiteSpline.pdf] Abort trap: 6
make[1]: *** [Bode.pdf] Abort trap: 6
make[1]: *** [GaussianSurface.pdf] Abort trap: 6
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_asymptote/asymptote/work/asymptote-2.70/doc'

which is 65584

[kencu (Ken)]

I put some WIP fixes here:

​https://github.com/kencu/macports-ports/tree/asymptoteupdate/graphics/asymptote

update to 2.83, updated the patch for 2.83, moved to python 3.10

but it still doesn't build through, as there are remaining issues.

[ryandesign (Ryan Carsten Schmidt)]

Replying to kencu:

which is 65584

Ken, if those crashes are still what's blocking your latest version, could you attach a crash log to that ticket?

[kencu (Ken)]

done.

[ryandesign (Ryan Carsten Schmidt)]

In 1ff69076611d7680b770f872e41283a2d74fcfba/macports-ports (master):

asymptote: De-fuzz patchfile

Closes: #66100