Opened 18 years ago

Closed 18 years ago

#6612 closed defect (fixed)

[PHP5] Include PDO Support for MySQL and PostgreSQL Variants

Reported by: jwthompson2@… Owned by: macports-tickets@…
Priority: High Milestone:
Component: ports Version: 1.0
Keywords: Cc: markd@…
Port:

Description

It would be helpful if the following lines got added to the variant sections to enable PDO driver compilation at install time:

For MySQL*: configure.args-append --with-pdo-mysql=${prefix}

For PostgreSQL: configure.args-append --with-pdo-pgsql=${prefix}/lib/pgsql8/bin/

Attachments (3)

Portfile.diff (1.4 KB) - added by opendarwin-2006@… 18 years ago.
patch for mysql3, mysql4, mysql5 and postgresql variants
php5-Portfile.diff (1.4 KB) - added by opendarwin-2006@… 18 years ago.
corrected patch for pdo support in mysql3, mysql4, mysql5 and postgresql variants
php5-Portfile-patch.diff (1.6 KB) - added by opendarwin-2006@… 18 years ago.
final patch for pdo support in mysql3, mysql4, mysql5 and postgresql variants

Download all attachments as: .zip

Change History (8)

Changed 18 years ago by opendarwin-2006@…

Attachment: Portfile.diff added

patch for mysql3, mysql4, mysql5 and postgresql variants

Changed 18 years ago by opendarwin-2006@…

Attachment: php5-Portfile.diff added

corrected patch for pdo support in mysql3, mysql4, mysql5 and postgresql variants

comment:1 Changed 18 years ago by opendarwin-2006@…

attachments.isobsolete: 01

Changed 18 years ago by opendarwin-2006@…

Attachment: php5-Portfile-patch.diff added

final patch for pdo support in mysql3, mysql4, mysql5 and postgresql variants

comment:2 Changed 18 years ago by opendarwin-2006@…

attachments.isobsolete: 01

comment:3 Changed 18 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: newclosed

Patch committed.

comment:4 Changed 18 years ago by charles.friedman@…

Resolution: fixed
Status: closedreopened

The PostgreSQL settings didn't work for me. I installed PostgreSQL 8.1 via port (tested and working), and it put it in the the directory .../postgresql81/... not .../pgsql8/...

Changing lines 179 and 180 of the php5 Portfile from


configure.args-append --with-pgsql=${prefix}/lib/pgsql8/bin \

--with-pdo-pgsql=${prefix}/lib/pgsql8/bin


to


configure.args-append --with-pgsql=${prefix}/lib/postgresql81/bin \

--with-pdo-pgsql=${prefix}/lib/postgresql81/bin


resulted in a successful (and functioning) build.

Note that line 178 of the Portfile already contained the correct postgresql81 dependency:

depends_lib-append port:postgresql81

Sorry, I don't know the Portfile configuration system well enough yet to propose a patch (I'm getting there), but is there a way to dynamically set/test the path (perhaps a glob, as I've seen in some other Portfiles)?

comment:5 Changed 18 years ago by markd@…

Cc: markd@… added
Resolution: fixed
Status: reopenedclosed

This was just fixed. Closing.

Note: See TracTickets for help on using tickets.