cfitsio @4.2.0 fails to build on 10.5.8: error: redefinition of typedef ‘ParseData’

[barracuda156]

In file included from eval.l:68:
eval_defs.h:21: error: redefinition of typedef ‘ParseData’
fitsio2.h:1022: error: previous declaration of ‘ParseData’ was here
eval_defs.h:22: error: redefinition of typedef ‘yyscan_t’
eval_l.c:338: error: previous declaration of ‘yyscan_t’ was here
In file included from eval.l:68:
eval_defs.h:21: error: redefinition of typedef ‘ParseData’
fitsio2.h:1022: error: previous declaration of ‘ParseData’ was here
eval_defs.h:22: error: redefinition of typedef ‘yyscan_t’
eval_l.c:338: error: previous declaration of ‘yyscan_t’ was here
fatal error: lipo: can't open input file: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_cfitsio/cfitsio/work/.tmp/cc6EA816.out (No such file or directory)
make[1]: *** [eval_l.o] Error 1

Same failure on 10.6 PPC (that is, +universal is not causing it).

[kencu (Ken)]

In a296293b673cb610855f8790386b010ff44c85cb/macports-ports (master):

cfitsio: fix build on older systems

required C11 typedef redefinitions
closes: #66330

fix /bin/cp patch to not use "-a" which is not supported on older systems
use the fallback equivalent instead, as before