logrotate: doesn't install default startitem

[catap (Kirill A. Korinsky)]

By default a logrotate says that I should simple run sudo port load logrotate to enable daily log rotation.

Anyway, running this command filed as:

Error: Failed to load logrotate: Launchd plist /Library/LaunchDaemons/org.macports.logrotate.plist was not found

because it hasn't created any startupitem by default.

[jmroot (Joshua Root)]

It's checking if {[variant_isset startupitem] but there is no such variant in the port. The code for installing the startupitem could be greatly simplified with the new startupitem.custom_file option in MacPorts 2.8. Something like this (untested):

sysutils/logrotate/Portfile

@@ -66 +66 @@
 
 destroot.keepdirs   ${destroot}${prefix}/etc/logrotate.d \
                     ${destroot}${prefix}/var/run/logrotate
+
+startupitem.type    launchd
+startupitem.create  no
+startupitem.custom_file ${worksrcpath}/org.macports.logrotate.plist.example
+
 post-destroot {
     xinstall -d ${destroot}${prefix}/share/${name}
         xinstall -m 644 -W ${worksrcpath} ChangeLog.md COPYING \
-            logrotate.conf.example org.macports.logrotate.plist.example \
+            logrotate.conf.example \
                 ${destroot}${prefix}/share/${name}
-
-    if {[variant_isset startupitem]
-    && ${startupitem.install} != "no"
-    && [getuid] == 0} {
-
-        xinstall -d ${destroot}${prefix}/etc/LaunchDaemons/org.macports.logrotate
-        xinstall -d ${destroot}/Library/LaunchDaemons
-        xinstall -m 644 ${destroot}${prefix}/share/${name}/org.macports.logrotate.plist.example \
-            ${destroot}${prefix}/etc/LaunchDaemons/org.macports.logrotate/org.macports.logrotate.plist
-        ln -sf "${prefix}/etc/LaunchDaemons/org.macports.logrotate/org.macports.logrotate.plist" "${destroot}/Library/LaunchDaemons/org.macports.logrotate.plist"
-    }
 }
 
 post-activate {

[ctreleaven (Craig Treleaven)]

@catap - Thanks for reporting this problem. The port has been broken for new installs since Feb 2019 and no one bothered to file a ticket! I should be able to fix this fairly quickly.

@jmroot - I was not aware of startupitem.custom_file and I usually pay attention to stuff related to daemons. I don't see this keyword mentioned in 'man portfile'. Where can I learn more about it?

[ctreleaven (Craig Treleaven)]

Found in the 2.8.0 release notes.

[ctreleaven (Craig Treleaven)]

In 5682ced6e70b17c1f2b4a26fab413e259b44adec/macports-ports (master):

logrotate: fix installing .conf file

revbump
use startupitem.customfile per jmroot suggestion
See: #66348

[jmroot (Joshua Root)]

Also documented in the Guide: ​https://guide.macports.org/chunked/reference.startupitems.html#reference.startupitems.attributes

[jmroot (Joshua Root)]

Looks like some of the buildbot workers (and so presumably some users also) have an existing unregistered /Library/LaunchDaemons/org.macports.logrotate.plist which will need to be cleaned up in pre-activate. Also, the notes still refer to the startupitem variant.

[ctreleaven (Craig Treleaven)]

Rats. I inherited that approach when I took over this port. It always seemed odd to handle the launchd plist so differently from logrotate.conf. In both cases, the objective was to preserve any customizations the user may have made. Since the plist has been broken for nearly 3 years, I'll assume that nobody feels a need to run it more or less frequently than daily.

[ctreleaven (Craig Treleaven)]

In 2253352cd4c1200a3b5cb66782a5aa21e9a251c9/macports-ports (master):

logrotate: delete unregistered plist

no revbump as this fixes cases where port failed installation
plist was formerly unreqistered, delete if found
remove superfluous notes
See: #66348

[ctreleaven (Craig Treleaven)]

Replying to catap:

By default a logrotate says that I should simple run sudo port load logrotate to enable daily log rotation.

Anyway, running this command filed as:

Error: Failed to load logrotate: Launchd plist /Library/LaunchDaemons/org.macports.logrotate.plist was not found

because it hasn't created any startupitem by default.

Could you please confirm if logrotate is now working for you?