#66487 closed defect (fixed)

gtk3 menues broken with macos ventura - update needed

Reported by: MStraeten (Martin Straeten) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version: 2.8.0
Keywords: Cc: ctreleaven (Craig Treleaven), parafin, Tuxie (Per Wigren), contextnerror, bll123 (Brad Lanam)
Port: gtk3 gtk3-devel

Description

gtk3 menues doesn't react on mouse hover on macos ventura reproducible with darktable but also with gtk3-demo (reported at gtk: https://gitlab.gnome.org/GNOME/gtk/-/issues/5305)

There seems to be a fix for that see https://gitlab.gnome.org/Infrastructure/gimp-macos-build/-/commit/d965dc994b8a770a592a1b47436ef6a70e010056

needs to be integrated in macports

Attachments (3)

patch-gtk3-devel_Portfile_v0.1.diff (5.1 KB) - added by ctreleaven (Craig Treleaven) 15 months ago.
patch to gtk3-devel
patch-meson_build.diff (258 bytes) - added by ctreleaven (Craig Treleaven) 15 months ago.
Updated gtk3-devel portfile uses this patch
patch-gtk3-devel_Portfile_v0.2.diff (5.1 KB) - added by bll123 (Brad Lanam) 13 months ago.
update to ctreleaven (Craig Treleaven)'s patch to bring the version up to 3.24.37. 3.24.36 had some display issues.

Download all attachments as: .zip

Change History (31)

comment:1 Changed 16 months ago by jmroot (Joshua Root)

Owner: set to mascguy
Status: newassigned

comment:2 Changed 15 months ago by dqh-au

(VICE emulator mac maintainer here, we use MacPorts to make our Intel binaries for macOS 10.10+)

This problem is fixed in 3.24.36, which Homebrew have updated to in the last couple of days.

Could MacPorts please update to 3.24.36?

comment:3 Changed 15 months ago by dqh-au

Ugh, they dropped autoconf so the port file needs to be updated to use meson :(

comment:4 Changed 15 months ago by ctreleaven (Craig Treleaven)

Cc: ctreleaven added

comment:5 Changed 15 months ago by ctreleaven (Craig Treleaven)

I believe this will affect gramps but don't have a Ventura system to check with. Upstream's bundled version was updated to address these issues:

https://gramps-project.org/bugs/view.php?id=12754

comment:6 Changed 15 months ago by parafin

Cc: parafin added

comment:7 Changed 15 months ago by Tuxie (Per Wigren)

Cc: Tuxie added

Changed 15 months ago by ctreleaven (Craig Treleaven)

patch to gtk3-devel

Changed 15 months ago by ctreleaven (Craig Treleaven)

Attachment: patch-meson_build.diff added

Updated gtk3-devel portfile uses this patch

comment:8 Changed 15 months ago by ctreleaven (Craig Treleaven)

Port: gtk3-devel added

Patch attached that will bring gtk3-devel up to 3.24.36. Tested +x11 variant only on OSX 10.15, Intel. Gramps, Zim, and Geany all seem to run normally.

To do:

+quartz - not tested yet
+universal - not tested.  Does meson still create problems for universal ports?
older systems - not tested. 
test suite - most tests fail; cause not apparent.  Should add logic to enable configure flag for tests.
Ventura: not tested to see if this actually fixes the menu problem on Ventura systems.

Questions:

Do we want to include gtk3 docs and demos with the port?  Should this be a variant?  Default or no?  
Portfile comments says "gobject-introspection uses g-ir-scanner, which uses $CC from env" but build seemed to finish OK without setting a CC variable?!?

Should I commit this to gtk3-devel so people can test (by activating gtk3-devel in place of gtk3)? Would also be interesting to see if it will build on the various buildbots.

comment:9 Changed 15 months ago by MStraeten (Martin Straeten)

just successfully built gtk3 @3.24.36_0+quartz (active) using your patches on macos ventura

comment:10 in reply to:  9 Changed 15 months ago by ctreleaven (Craig Treleaven)

Replying to MStraeten:

just successfully built gtk3 @3.24.36_0+quartz (active) using your patches on macos ventura

Just to be clear, are you saying that the menu problems with Darktable are fixed? Are you running any other gtk3 apps?

Are you running on Intel or Apple Silicone?

comment:11 Changed 15 months ago by MStraeten (Martin Straeten)

yes - the darktable menu issues are fixed with this gtk3 3.24.36 build (at least for my intel build https://discuss.pixls.us/t/current-osx-build/13213/594)
it was reported that these ventura issues are also fixed with homebrew build using gtk3 3.24.36 (https://github.com/darktable-org/darktable/issues/12727#issuecomment-1371836994)

comment:12 Changed 14 months ago by MStraeten (Martin Straeten)

now tried a build with m1 mac: the patched portfile isn't accepted:

gtk3-devel % sudo port upgrade outdated
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

comment:13 in reply to:  12 Changed 14 months ago by ctreleaven (Craig Treleaven)

Replying to MStraeten:

now tried a build with m1 mac: the patched portfile isn't accepted:

gtk3-devel % sudo port upgrade outdated
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

Could you please attach the main.log to this ticket? Thanks.

comment:14 Changed 14 months ago by MStraeten (Martin Straeten)

there’s no main.log created, just an empty .home and .temp in the …/gtk3-devel/work folder maybe something with the macports configuration since the patched portfile is fine on the old intel mac.

Last edited 14 months ago by MStraeten (Martin Straeten) (previous) (diff)

comment:15 Changed 14 months ago by ctreleaven (Craig Treleaven)

Since you have updated the Portfile via a patch, I don't think MacPorts will know that it is "outdated".

From the directory with the patched gtk3-devl port, try

sudo port -d install

Attach the log here.

comment:16 Changed 14 months ago by MStraeten (Martin Straeten)

it seemed the privileges weren’t set properly… so macports wasn‘t able to see the local ports directory… Build was fine so additional confirmation - the patch also works fine with m1

comment:17 Changed 14 months ago by MStraeten (Martin Straeten)

it seems there's an issue with handling of display color profiles when building gtk3.24.36 this way. see https://discuss.pixls.us/t/gamma-saturation-difference-between-dt-and-other-apps-on-mac/35038 this error occurs since i used the above patches to build gtk 3.24.36 so 2 possible reasons:

  • gtk3.24.36 brakes it or
  • something is missing in the portfile

comment:18 Changed 14 months ago by MStraeten (Martin Straeten)

got a homebrew build with gtk3 3.24.36 - it shows the same issue, so it's obviously not the portfile but an upstream issue with gtk3

comment:19 Changed 14 months ago by parafin

Colorspace issue was fixed with https://gitlab.gnome.org/GNOME/gtk/-/commit/312e5781f36e2014dc79ac4a82bea4f7fb57d9da But no release yet (I don't know if there's a schedule of some kind for GTK3 releases). Would be nice to have 3.24.36 with that patch applied in macports in the meantime. Is there some estimate of when it might happen?

comment:20 Changed 14 months ago by ctreleaven (Craig Treleaven)

Since the update to GTK 3.24.36 required moving to a Meson-based build system, there is a significant chance that universal builds are broken. I don't have the means to test. I'm not comfortable pushing a change that is likely to fix a problem for some and break the port for others. Especially since I'm not the maintainer of gtk3.

Perhaps try asking on macports-dev if someone can incorporate the simple patch above and work out what, if anything, needs to be done so the port will build univerrsal?

comment:21 Changed 13 months ago by contextnerror

Cc: contextnerror added

Changed 13 months ago by bll123 (Brad Lanam)

update to ctreleaven (Craig Treleaven)'s patch to bring the version up to 3.24.37. 3.24.36 had some display issues.

comment:22 Changed 13 months ago by bll123 (Brad Lanam)

Cc: bll123 added

comment:23 Changed 11 months ago by mascguy (Christopher Nielsen)

FYI, a work-in-progress PR has been created:

18386 - gtk3-devel: update to 3.24.37, including migration to Meson

Still refining the dependencies, but it's close to completion. Feedback welcome!

comment:24 Changed 11 months ago by MStraeten (Martin Straeten)

build on m1 ventura 13.3.1 was fine - no issues with darktable

comment:25 Changed 11 months ago by Christopher Nielsen <mascguy@…>

Resolution: fixed
Status: assignedclosed

In 4a787103ec28c9ec4562e286856f23bf3effe3f5/macports-ports (master):

gtk3-devel: update to 3.24.37

  • Thanks to @ctreleaven for help with patching

Fixes: #66487
Fixes: #66899

comment:26 Changed 11 months ago by mascguy (Christopher Nielsen)

Resolution: fixed
Status: closedreopened

Reopening, as the quartz variant is failing to build on older macOS releases [for gtk3-devel]. Looks like we'll need an additional patch; currently investigating.

comment:27 Changed 11 months ago by Christopher Nielsen <mascguy@…>

In f28ddf82c41410a1375d5221acc5c46beedfbf01/macports-ports (master):

gtk3-devel: add new quartz-related patches for 3.24.37
See: #66487
See: #66899

comment:28 Changed 11 months ago by Christopher Nielsen <mascguy@…>

Resolution: fixed
Status: reopenedclosed

In 5dce2ee05f1275a3f720a8ab8eca3c7f8a656ee1/macports-ports (master):

gtk3: update to 3.24.37; add new quartz-related patches
Fixes: #66487
Fixes: #66899

Note: See TracTickets for help on using tickets.