sshuttle: can't read "env(USER)": no such variable

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/ports-13_x86_64-builder/builds/5801/steps/install-port/logs/stdio

DEBUG: Executing proc-pre-org.macports.destroot-destroot-1
DEBUG: Executing proc-pre-org.macports.destroot-destroot-2
Error: Failed to destroot sshuttle: can't read "env(USER)": no such variable
DEBUG: Error code: NONE
DEBUG: Backtrace: can't read "env(USER)": no such variable

[jmroot (Joshua Root)]

I expect this is not Ventura-specific, but is likely rare outside of the buildbot environment, though anyone could have USER unset. It should probably be using either ${macportsuser} or ${install.user} depending on what it's trying to accomplish. (And should presumably only be attempted when running as root.) What user do the files belong to to begin with, anyway?

[kencu (Ken)]

that bit of code was added to fix this issue 65331

[kencu (Ken)]

In 056d7f570c7c0215d04ee4e10a439b429dbc1cce/macports-ports (master):

sshuttle: only change ownership if USER exists

closes: #66542

[ryandesign (Ryan Carsten Schmidt)]

That didn't fix it. You wrote in the commit message that you're checking if USER exists, but you're actually checking whether it's not empty, which is different.

[kencu (Ken)]

Ah, darn -- it's hard for me to test the buildbot setup.

Thanks for following it up.

[jmroot (Joshua Root)]

In c6ba3c0f6a9ba48d5370921933edb69fd10852d5/macports-ports (master):

sshuttle: don't rely on env(USER) existing

Fixes: #66542