Opened 18 years ago

Closed 18 years ago

#6698 closed defect (fixed)

jove: [PATCH] new upstream version 4.16.0.69

Reported by: blair (Blair Zajac) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.0
Keywords: Cc: vivek@…, olegb@…
Port:

Description

I am uploading a new Portfile for the latest version of jove 4.16.0.69.

This new version of jove contains many of the fixes that DarwinPorts had as patches, mostly for the mkstemp() code, so all but the Makefile patch is removed.

The only major differences between what I am uploading and the current version of jove in DarwinPorts is:

1) Change optimization to -Os. 2) Add a jove-local.rc file that defines these key bindings +bind-to-key query-replace-string [% +bind-to-key suspend-jove Z +bind-to-key insert-file Xi 3) Compile with -DBSDPOSIX_STDC instead of -DBSDPOSIX.

BTW, I maintain this package for Fink and these changes have been in use there for over a year.

Regards, Blair

Attachments (3)

Portfile (707 bytes) - added by blair (Blair Zajac) 18 years ago.
New Portfile
patch-Makefile.diff (2.6 KB) - added by blair (Blair Zajac) 18 years ago.
New patch-Makefile.diff
patch-jove-local.rc.diff (276 bytes) - added by blair (Blair Zajac) 18 years ago.
New patch to add jove-local-rc.

Download all attachments as: .zip

Change History (8)

Changed 18 years ago by blair (Blair Zajac)

Attachment: Portfile added

New Portfile

Changed 18 years ago by blair (Blair Zajac)

Attachment: patch-Makefile.diff added

New patch-Makefile.diff

Changed 18 years ago by blair (Blair Zajac)

Attachment: patch-jove-local.rc.diff added

New patch to add jove-local-rc.

comment:1 Changed 18 years ago by olegb@…

Cc: vivek@… olegb@… added

adding maintainer as cc; so that the maintainer can have a say too. Though it seems fine to include.

comment:2 Changed 18 years ago by vivek@…

I'm fine with these updates, except for the jove-local.rc file. There's no reason to muck about with keybindings on a global config file.

comment:3 Changed 18 years ago by blair (Blair Zajac)

Concerning the jove-local.rc, please at least put this line in there:

bind-to-key suspend-jove Z

Without this, you can't even suspend jove.

Regards, Blair

comment:4 Changed 18 years ago by vivek@…

You can always bind whatever keys you want in your own personal private .joverc file, or you can run the suspend-jove command via the M-x command key. My default binding is _ which is common to all my emacs bindings (I'm an old Gosmacs keybinding guy)

Again, there is ZERO reason to alter keybindings in a global file.

comment:5 Changed 18 years ago by olegb@…

Resolution: fixed
Status: newclosed

commited - though i have followed the maintainers advice *not* to touch jove-local-rc

Thanks guys.

Note: See TracTickets for help on using tickets.