Opened 21 months ago

Closed 13 months ago

Last modified 12 months ago

#70118 closed defect (fixed)

openfortivpn needs vdprintf implementation to fix older systems

Reported by: barracuda156 Owned by: millerdev (Daniel Miller)
Priority: Normal Milestone:
Component: ports Version: 2.9.3
Keywords: tiger, leopard, snowleopard Cc:
Port: openfortivpn, legacysupport

Description

We can fix headers checks either directly: https://github.com/adrienverge/openfortivpn/pull/1224 Or simply by adding legacysupport.

However, we still need legacysupport anyway for memmem:

checking for memmem... no
configure: error: Required function not found

That done, the build fails further on a missing vdprintf:

  CCLD     openfortivpn
Undefined symbols:
  "_vdprintf", referenced from:
      _pinentry_exchange in openfortivpn-userinput.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

I do not have a fix for this. Issue with upstream: https://github.com/adrienverge/openfortivpn/issues/1223

This could be fixed via legacysupport, but implementation should be added into it.

  1. S. Another ticket mentioning vdprintf was #67598

Change History (2)

comment:1 Changed 13 months ago by fhgwright (Fred Wright)

Resolution: fixed
Status: assignedclosed

In e5cdc7ae6e22afebb2a5df15e7588dfdc2662fd9/macports-ports (master):

legacy-support-devel: Update to latest master.

Notable changes since last -devel version:

  • Fixes 10.4 Rosetta bug in fstatx_np()
  • Makes renameat() available via stdio.h See: #71842
  • Implements interim clock_gettime_nsec_np() See: #61691
  • Implements clock_settime() See: #71399
  • Adds net/if_tun.h for <10.6 See: #70231
  • Provides pthread_[f]chdir_np() for 10.5+ See: #71265
  • Adds CPU_TYPE_ARM definition for 10.4 See: #71621

Also adds Portfile comments regarding suggested github.tarball_from
change.

Also, the prior addition of vdprintf() in v20241026 neglected to close
the related tickets:

Closes: #67598
Closes: #70118

TESTED:
Tested both normal and -devel versions -/+universal on 10.4-10.5 ppc,
10.5-10.6 ppc (i386 Rosetta), 10.4-10.6 i386, 10.4-12.x x86_64, and
11.x-15.x arm64.
Builds and passes all tests on all tested platforms.

comment:2 Changed 12 months ago by fhgwright (Fred Wright)

In a784d15ced04e75724ee259cec1f7a3d1ab696d3/macports-ports (master):

legacy-support: update to v1.4.0.

Notable changes since v1.3.0:

  • Works around Apple's broken versioning in the macOS 15 SDK
  • Implements scandir() compatibility feature
  • Fixes dprintf() bug and implements vdprintf() See: #67598 See: #70118
  • Mismatched SDK compatibility is extended to include 15.x SDK.
  • Broken 10.4 CLOCK_MONOTONIC is fixed.
  • Fixes stat inconsistency in some 32-bit 10.4 builds.
  • Adds stat64 header support for 10.4 SDK.
  • Adds INODE64 support for *stat*() on 10.4.
  • Reworks fstatat*() support, similar to previous item, fixing buffer overrun in some cases.
  • Backports 10.5 'which' to 10.4.
  • Adds support for code that can't tolerate the normal scandir() compatibility feature.
  • Replaces broken 10.4/10.5 copyfile wrapper with full 10.6 copyfile.
  • Extends 10.4 INODE64 support to *statx_np() functions.
  • Expands TARGET_* defaults. See: #70824
  • Fixes 10.4 Rosetta bug in fstatx_np()
  • Makes renameat() available via stdio.h See: #71842
  • Implements interim clock_gettime_nsec_np() See: #61691
  • Implements clock_settime() See: #71399
  • Adds net/if_tun.h for <10.6 See: #70231
  • Provides pthread_[f]chdir_np() for 10.5+ See: #71265
  • Adds CPU_TYPE_ARM definition for 10.4 See: #71621

TESTED:
Tested both normal and -devel versions -/+universal on 10.4-10.5 ppc,
10.5-10.6 ppc (i386 Rosetta), 10.4-10.6 i386, 10.4-12.x x86_64, and
11.x-15.x arm64.
Builds and passes all tests on all tested platforms.

Note: See TracTickets for help on using tickets.