ripgrep @14.1.0: Missing dependency on libiconv

[Tblue (Tilman Blumenbach)]

I just tried to install ripgrep on a fresh MacPorts installation, and it failed:

# port install -v ripgrep
[...trimmed...]
--->  Installing ripgrep @14.1.0_0
--->  Activating ripgrep @14.1.0_0
[...trimmed...]
--->  Scanning binaries for linking errors
Could not open /opt/local/lib/libiconv.2.dylib: Error opening or reading file (referenced from /opt/local/bin/rg)
--->  Found 1 broken file, matching files to ports
--->  Found 1 broken port, determining rebuild order
You can always run 'port rev-upgrade' again to fix errors.
The following ports will be rebuilt: ripgrep @14.1.0
Continue? [Y/n]: n

Installing the libiconv port fixed the issue, so it looks like there's a missing dependency that needs to be mentioned in the Portfile of ripgrep.

---

• macOS 14.6.1
• Xcode command-line tools only, v 15.3.0.0.1.1708646388

[raimue (Rainer Müller)]

Dropping maintainership of ripgrep.

[TheRealKeto (Keto)]

In 944a4162a6a69f8db01b58563c9faea9db3c1a17/macports-ports (master):

gitu: Update to 0.28.2

See: #70646

[ryandesign (Ryan Carsten Schmidt)]

Keto, in the above commit, you seem to have fixed the problem by adding the libiconv dependency.

You also added a comment claiming this is a bug in the rust portgroup. Is there a ticket for that bug? In a quick search I didn't find a MacPorts ticket but I did find ​this rust bug which was fixed a couple years ago.

[ryandesign (Ryan Carsten Schmidt)]

Oh I see why you didn't close this ticket: your commit fixed the gitu port; this ticket is for the ripgrep port.

[TheRealKeto (Keto)]

Replying to ryandesign:

Oh I see why you didn't close this ticket: your commit fixed the gitu port; this ticket is for the ripgrep port.

I just provided a reference on how to close this ticket, but it seems that there's no need for it. I briefly tested on ripgrep and ruff without the fix referenced, and the binary still worked. This issue goes further than just one port, and should really be looked at closely; might even be relevant to look at the issue you linked.

In short, libiconv somehow gets linked to Rust ports without it being necessary, which forces the unnecessary rev-upgrade

[dgilmanAIDENTIFIED (David Gilman)]

In bdc26f7f9b6fa502de4cb777bd865f786ed4607f/macports-ports (master):

ripgrep: make pcre variant default

Also add (unused) dependency on iconv.
See #73654 for tracking the
underlying rustc issue.

Closes: #70646