qemu @9.1.0: error: implicit declaration of function 'pthread_jit_write_protect_np' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

[tom-programming]

qemu fails on compilation in macOS 10.15 (Catalina) with newest command line tools

error is:

:info:build In file included from qapi/qapi-visit-authz.c:13:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_qemu/qemu/work/qemu-9.1.0/include/qemu/osdep.h:803:5: error: implicit declaration of function 'pthread_jit_write_protect_np' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     pthread_jit_write_protect_np(true);
:info:build     ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_emulators_qemu/qemu/work/qemu-9.1.0/include/qemu/osdep.h:808:5: error: implicit declaration of function 'pthread_jit_write_protect_np' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build     pthread_jit_write_protect_np(false);
:info:build     ^
:info:build 2 errors generated.

which suggest to me lack of an include pthreads.h directive

[ryandesign (Ryan Carsten Schmidt)]

pthread_jit_write_protect_np is only available in macOS 11 and later. I could not find a web page stating that, but in the file /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/include/pthread/pthread.h on my system the function is declared as:

__API_AVAILABLE(macos(11.0))
__API_UNAVAILABLE(ios, tvos, watchos, driverkit)
void pthread_jit_write_protect_np(int enabled);

The qemu developers deliberately removed the compatibility code that used to allow it to compile on macOS 10.x:

​https://gitlab.com/qemu-project/qemu/-/commit/7b60b971cc2f52ed2a69006a2ad709df2831cd67

The maintainer of the qemu port has previous expressed disinterest in supporting older versions of macOS than the developers of qemu do.

[cooljeanius (Eric Gallager)]

I also get one of these for IOMainPort when compiling on x86_64 Big Sur with Xcode 13, FWIW:

../qemu-9.1.1/block/file-posix.c:3942:18: error: implicit declaration of function 'IOMainPort' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    kernResult = IOMainPort(MACH_PORT_NULL, &mainPort);
                 ^
1 error generated.

(this blocks upgrading of macpine, lima, and colima for me, btw)

[brendonjkding (Brendon)]

Hi, here's all the patches needed to compile on macOS 10.15. Hope it helps. :)

​https://github.com/koucyuu/qemu_catalina_patches

[cooljeanius (Eric Gallager)]

Replying to brendonjkding:

Hi, here's all the patches needed to compile on macOS 10.15. Hope it helps. :)

​https://github.com/koucyuu/qemu_catalina_patches

Do these fix #71593 too?