#70824 closed defect (fixed)
legacy-support provide TARGET_OS_IPHONE
| Reported by: | rmottola (Riccardo) | Owned by: | fhgwright (Fred Wright) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | legacy-support | Version: | |
| Keywords: | Cc: | ||
| Port: | legacy-support |
Description
I noticed that several ports start "breaking" because of TARGET_OS_IPHONE not being defined. E.g. https://github.com/LuaJIT/LuaJIT/pull/1189/files
The fix is incredibly trivial, but upstream often forgets about that. We can fight and make a patch for each and maintain it or hope it is upstreamed. However, often legacy-support is already used. I wonder if there is a good place and way to define it? Of course to 0, NO, or what is needed. We don't need those code sections at all on Mac
Change History (5)
comment:1 Changed 16 months ago by kencu (Ken)
comment:2 Changed 12 months ago by fhgwright (Fred Wright)
| Owner: | set to fhgwright |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:3 Changed 12 months ago by fhgwright (Fred Wright)
comment:4 Changed 11 months ago by fhgwright (Fred Wright)
comment:5 Changed 9 months ago by mascguy (Christopher Nielsen)
| Component: | ports → legacy-support |
|---|
Recategorize existing legacy-support lib tickets, to use new component definition.
Note: See
TracTickets for help on using
tickets.

add here
https://github.com/macports/macports-legacy-support/blob/master/include/TargetConditionals.h