nodejs14: disable a few warnings-as-errors for successful build on 10.7.5 (11G63)

[i3roly]

adding:

-Wno-error -Wno-enum-constexpr-conversion -Wno-incompatible-function-pointer-types -Wno-implicit-function-declaration

resulted in a successful build of nodejs14 on 10.7.5.

i thought it would be helpful to bring this to the attention of the maintainer so others could benefit, like my buddy fred.

[ryandesign (Ryan Carsten Schmidt)]

Presuming that the build failed before adding these flags, customarily we would like you to attach the compressed main.log file showing what the problem was.

Since you already know what the fix is you could submit it as a pull request.

There are many nodejs ports in MacPorts, for different versions of nodejs. It would be good to make the same fix to all affected versions.

[i3roly]

i can report that nodejs18, unlike the comment in the port file, should work if we are requiring llvm-17 and clang-17, however the portfile is not currently set up to handle the libc++ in /opt/local/libexec/llvm-17/lib/libc++ and so right now i had to hard-code the link in to see if it work.s

same CFLAGS/CXXFLAGS/CPPFLAGS as mentioned above. will try to spin another build soon that puts /opt/local/libexec/llvm-17/lib on the path (or is this forbidden)?

either way, for older OS users, this introduction of a non /usr/lib symlink may be worth the functionality of a new nodejs.

[i3roly]

build lawg

[i3roly]

cleaner log. adding C{XX,PP,{}}FLAGS "-Wno-incompatible-function-pointer-types -Wno-enum-constexpr-conversion" and LDFLAGS="-L/opt/local/lib/libexec/llvm-17/lib/libc++"

[kencu (Ken)]

for this error:

../deps/v8/src/base/bit-field.h:43:29: error: integer value 31 is outside the valid range of values [0, 15] for this enumeration type [-Wenum-constexpr-conversion]
  static constexpr T kMax = static_cast<T>(kNumValues - 1);

there is interesting discussion here:

​https://github.com/nodejs/node/issues/52230

and this commit into v8 in chromium is related:

​https://github.com/v8/v8/commit/d15d49b09dc7aef9edcc4cf6a0cb2b77a0db203f

[i3roly]

nodejs22_success

[mascguy (Christopher Nielsen)]

Fixed by recently merged PR:

​https://github.com/macports/macports-ports/pull/26031