xar @1.8.0.501_0 - Fails to Build on El Capitan - error: expected function body after function declarator

[RobK88]

xar@1.8.0.501_0 fails to Build on El Capitan -- error: expected function body after function declarator.

grinch$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.6
BuildVersion:	15G22010

grinch$ port outdated
The following installed ports are outdated:
cmus                           2.11.0_1 < 2.11.0_3       
xar                            1.8.0.498_0 < 1.8.0.501_0  

grinch$ sudo port clean xar
--->  Cleaning xar
 
grinch$ sudo port upgrade xar
--->  Computing dependencies for xar
--->  Fetching archive for xar
--->  Attempting to fetch xar-1.8.0.501_0+universal.darwin_15.i386-x86_64.tbz2 from http://packages.macports.org/xar
--->  Attempting to fetch xar-1.8.0.501_0+universal.darwin_15.i386-x86_64.tbz2 from https://mirrors.mit.edu/macports/packages/xar
--->  Attempting to fetch xar-1.8.0.501_0+universal.darwin_15.i386-x86_64.tbz2 from http://bos.us.packages.macports.org/xar
--->  Fetching distfiles for xar
--->  Verifying checksums for xar
--->  Extracting xar
--->  Applying patches to xar
--->  Configuring xar
--->  Building xar                                       
Error: Failed to build xar: command execution failed     
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_xar/xar/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.

[RobK88]

main.log

[RobK88]

Please note that I am upgrading the +universal variant of xar.

[Schamschula (Marius Schamschula)]

I'm going to have to look into this.

The build bot had a clean build (for the non-universal version) yesterday, before I updated the Portfile to deal with macOS versions that entirely fail to build xar 1.8.0.501.

I need to check if El Capitan gets the correct patch file for src/xar_internal.h.

[ryandesign (Ryan Carsten Schmidt)]

From the log:

src/xar_internal.h:18:49: error: expected function body after function declarator
xar_t xar_open(const char *file, int32_t flags) API_AVAILABLE(macos(10.4));
                                                ^

We've had this problem with this port before; see #64837.

[Schamschula (Marius Schamschula)]

Ryan,

As I was researching the build bot failures yesterday, I ran across that ticket.

Unfortunately, there seems to be more going on here. That's why I rolled the broken builds back to the previous version so I can research the multiple failures.

The El Capitan build should not have failed, as the build bot was successful.

[Schamschula (Marius Schamschula)]

For some reason the patch-src-xar_internal.h.diff is not being applied.

[Schamschula (Marius Schamschula)]

Found it!

[Schamschula (Marius Schamschula)]

See: ​https://github.com/macports/macports-ports/commit/5cbdd3b55e903d53e46e571c94156113d4b8ac29

[RobK88]

Marius - Thanks for finding and fixing the bugs in the Portfile. I was able to upgrade xar +universal to the latest version on El Capitan.

grinch$ port installed xar
The following ports are currently installed:
  xar @1.8.0.498_0
  xar @1.8.0.498_0+universal (active)

grinch$ port outdated
The following installed ports are outdated:
cmus                           2.11.0_1 < 2.11.0_3       
xar                            1.8.0.498_0 < 1.8.0.501_0   

grinch$ sudo port upgrade xar
--->  Computing dependencies for xar
--->  Fetching archive for xar
--->  Attempting to fetch xar-1.8.0.501_0+universal.darwin_15.i386-x86_64.tbz2 from http://packages.macports.org/xar
--->  Attempting to fetch xar-1.8.0.501_0+universal.darwin_15.i386-x86_64.tbz2 from https://mirrors.mit.edu/macports/packages/xar
--->  Attempting to fetch xar-1.8.0.501_0+universal.darwin_15.i386-x86_64.tbz2 from http://bos.us.packages.macports.org/xar
--->  Fetching distfiles for xar
--->  Verifying checksums for xar
--->  Extracting xar
--->  Applying patches to xar
--->  Configuring xar
--->  Building xar                                       
--->  Staging xar into destroot                          
--->  Installing xar @1.8.0.501_0+universal              
--->  Cleaning xar
--->  Computing dependencies for xar
--->  Deactivating xar @1.8.0.498_0+universal
--->  Cleaning xar
--->  Activating xar @1.8.0.501_0+universal
--->  Cleaning xar
--->  Scanning binaries for linking errors
--->  No broken files found.                             
--->  No broken ports found.

grinch$ port installed xar
The following ports are currently installed:
  xar @1.8.0.498_0
  xar @1.8.0.498_0+universal
  xar @1.8.0.501_0+universal (active)
 
grinch$ xar --version
xar 1.8dev