valkey @8.0.1: Build error

[GarrettAlbright (Garrett Albright)]

Valkey 8.0.1 is failing to build. This is happening both on my work machine which has 8.0.0 installed and on my laptop which has no previous version installed. Both are M1 machines.

The attached main.log file seems to indicate issues related to Lua. Lua doesn't seem to be a dependency though. I do have the standard "lua" package (@5.3.6) and some related stuff installed, if that helps.

[ryandesign (Ryan Carsten Schmidt)]

It looks like valkey might have a bundled copy of lua. It could be getting confused by the MacPorts lua that you have installed, inadvertently using parts of MacPorts lua instead of its own version. If so, that is a bug that we should fix. To verify whether that's the case, try this:

sudo port clean valkey
sudo port -f deactivate lua
sudo port install valkey

You can sudo port activate lua again afterward if you like.

[mohd-akram (Mohamed Akram)]

In 80fe9a62668d13226326509c23da58d0cce1e546/macports-ports (master):

valkey: fix build conflict with lua

Fixes: #71078

[mohd-akram (Mohamed Akram)]

This was already fixed but it was reverted when I updated Valkey to 8.0.1 while cleaning up the portfile. I added the same code back. I hadn't seen #40656 so the fix seemed weird and probably outdated, but -isystem makes a bit more sense now.

[GarrettAlbright (Garrett Albright)]

The port builds for me now. Thank you!