Opened 5 weeks ago
Last modified 5 weeks ago
#71231 assigned enhancement
p5-sub-handlesvia test 50objectpad.t fails because it uses has instead of field
Reported by: | ballapete (Peter "Pete" Dyballa) | Owned by: | dbevans (David B. Evans) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.10.2 |
Keywords: | highsierra | Cc: | |
Port: | p5-sub-handlesvia |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
The issue is described here: https://github.com/tobyink/p5-sub-handlesvia/issues/16. The patch is taken from here: https://github.com/tobyink/p5-sub-handlesvia/pull/17/commits/800654ad66fe555e429af3a81cea76cdf6f453fe.
I found it when testing whether Perl 5.38 can be a substitute for Perl 5.34.
BTW, are there some ideal Portfile
s for Perl modules? That take into account that some other Perl module are needed at run time, some to build it, and some others for testing?
I expanding the original Portfile
to
1 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 2 3 PortSystem 1.0 4 PortGroup perl5 1.0 5 6 perl5.branches 5.28 5.30 5.32 5.34 5.38 7 perl5.setup Sub-HandlesVia 0.050000 ../../authors/id/T/TO/TOBYINK 8 revision 0 9 license {Artistic-1 GPL} 10 maintainers {devans @dbevans} openmaintainer 11 description Sub::HandlesVia - alternative handles_via implementation 12 long_description ${description} 13 14 platforms {darwin any} 15 supported_archs noarch 16 17 checksums rmd160 83f1f81c918bfa5aed65d8f13dafd08448c6f9f6 \ 18 sha256 2df93493e2f9e95be579b950b6e19ff524f94c80613aadc03a88611dff75794f \ 19 size 176211 20 21 patchfiles patch-field-instead-of-has_t-50objectpad.t.diff 22 23 if {${perl5.major} != ""} { 24 depends_build-append \ 25 port:p${perl5.major}-class-tiny \ 26 port:p${perl5.major}-moo \ 27 port:p${perl5.major}-moox-typetiny \ 28 port:p${perl5.major}-moose \ 29 port:p${perl5.major}-moosex-arrayref \ 30 port:p${perl5.major}-moosex-extended \ 31 port:p${perl5.major}-moosex-insideout \ 32 port:p${perl5.major}-mouse \ 33 port:p${perl5.major}-object-pad \ 34 port:p${perl5.major}-test-fatal \ 35 port:p${perl5.major}-test-requires \ 36 port:p${perl5.major}-try-tiny 37 38 depends_lib-append \ 39 port:p${perl5.major}-class-method-modifiers \ 40 port:p${perl5.major}-exporter-tiny \ 41 port:p${perl5.major}-role-hooks \ 42 port:p${perl5.major}-role-tiny \ 43 port:p${perl5.major}-scalar-list-utils \ 44 port:p${perl5.major}-type-tiny 45 } 46 # Test requires modules 'Beam::Wire', 'MooX::ProtectedAttributes', 'MooX::Should'
but do not know whether its in correct form for release. There is, IMO, the problem that some test files starts with #!/usr/bin/perl
which would make them test with macOS' Perl. Can't this be handled by port
? (At least for some modules that won't PASS but FAIL tests I am trying to patch those lines to see where the error comes from.)
Attachments (1)
Change History (2)
Changed 5 weeks ago by ballapete (Peter "Pete" Dyballa)
Attachment: | patch-field-instead-of-has_t-50objectpad.t.diff added |
---|
comment:1 Changed 5 weeks ago by ryandesign (Ryan Carsten Schmidt)
Cc: | devans@… removed |
---|---|
Description: | modified (diff) |
Owner: | set to dbevans |
Status: | new → assigned |
The patch file