Opened 3 months ago
Last modified 3 months ago
#71262 assigned update
hidapi: Update to 0.14.0 and switch to cmake
| Reported by: | DanielO (Daniel O'Connor) | Owned by: | raimue (Rainer Müller) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | hidapi |
Description
I need the cmake files for hidapi to build a project which means it needs to be built with cmake (the .pc file is still installed). Also updates to the latest version.
Attachments (1)
Change History (8)
Changed 3 months ago by DanielO (Daniel O'Connor)
| Attachment: | hidapi-0.14.0-cmake.diff added |
|---|
comment:1 Changed 3 months ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | set to raimue |
|---|---|
| Status: | new → assigned |
| Summary: | hiadpi 0.14.0: Update and switch to cmake → hidapi 0.14.0: Update and switch to cmake |
comment:2 Changed 3 months ago by DanielO (Daniel O'Connor)
Ah I see, I searched for hidapi before filing the bug but didn't read the bug in detail so missed this..
Does not building the static library impact other ports?
comment:3 Changed 3 months ago by ryandesign (Ryan Carsten Schmidt)
Probably nobody should be using static libraries, however historically we have typically offered both static and dynamic libraries in ports where possible, probably because that was the default behavior of most autotools build systems.
The lack of static libraries isn't the big problem; the regression of the library's minor version number is.
comment:4 follow-up: 6 Changed 3 months ago by DanielO (Daniel O'Connor)
Perhaps a patch to have the cmake build use a version number that doesn't go backwards is the way forward. I have no idea how difficult that is in practise though.
comment:5 Changed 3 months ago by ryandesign (Ryan Carsten Schmidt)
| Summary: | hidapi 0.14.0: Update and switch to cmake → hidapi: Update to 0.14.0 and switch to cmake |
|---|
Replying to DanielO:
I need the cmake files for hidapi to build a project which means it needs to be built with cmake
If the autotools build doesn't install needed files, that bug should be reported to the developers.
(the .pc file is still installed).
This bug report says there is a problem with the .pc file when built with cmake: https://github.com/libusb/hidapi/issues/638
comment:6 Changed 3 months ago by ryandesign (Ryan Carsten Schmidt)
Replying to DanielO:
Perhaps a patch to have the cmake build use a version number that doesn't go backwards is the way forward. I have no idea how difficult that is in practise though.
As I reported to the developers, in the cmake build system they have erroneously coupled the library version number to the project version number, so this is not easy to correct. The developers have declined to consider this decision an error.
comment:7 Changed 3 months ago by DanielO (Daniel O'Connor)
I meant we could patch the hidapi CMakeLists.txt and do the version in a backwards compatible way.
I did have an update to hidapi 0.14.0 in progress some time ago to fix #67189. Note what I said there about why switching to the cmake build system would be bad, which is why the update I was working on does not do that.