Opened 15 months ago

Closed 13 months ago

Last modified 10 months ago

#71399 closed defect (fixed)

legacysupport: provide clock_settime

Reported by: barracuda156 Owned by: fhgwright (Fred Wright)
Priority: Normal Milestone:
Component: legacy-support Version: 2.10.5
Keywords: Cc: fhgwright (Fred Wright), mascguy (Christopher Nielsen), macportsraf
Port: legacy-support, legacy-support-devel

Description

Some ports need not only clock_gettime, but the reverse as well. For example #53928 but also other ones.

Is it possible to add it?

Change History (5)

comment:1 Changed 15 months ago by fhgwright (Fred Wright)

Anything's "possible". :-)

In most cases, the bulk of the work is in the test, rather than the implementation. In this particular case, it would have to be a manual test, for obvious reasons.

ntpsec is actually a poor example, since the unpatched upstream code has _way_ more issues than just clock_settime. I should know, since I'm the maintainer. :-)

Last edited 15 months ago by fhgwright (Fred Wright) (previous) (diff)

comment:2 Changed 13 months ago by fhgwright (Fred Wright)

Owner: set to fhgwright
Resolution: fixed
Status: newclosed

In 9f6e0d24cf4b74cfc29645cfd4ac538fca580613/macports-legacy-support (master):

Implement clock_settime().

Closes: #71399

TESTED:
Passes the new (manual) test on all platforms.

comment:3 Changed 13 months ago by fhgwright (Fred Wright)

In e5cdc7ae6e22afebb2a5df15e7588dfdc2662fd9/macports-ports (master):

legacy-support-devel: Update to latest master.

Notable changes since last -devel version:

  • Fixes 10.4 Rosetta bug in fstatx_np()
  • Makes renameat() available via stdio.h See: #71842
  • Implements interim clock_gettime_nsec_np() See: #61691
  • Implements clock_settime() See: #71399
  • Adds net/if_tun.h for <10.6 See: #70231
  • Provides pthread_[f]chdir_np() for 10.5+ See: #71265
  • Adds CPU_TYPE_ARM definition for 10.4 See: #71621

Also adds Portfile comments regarding suggested github.tarball_from
change.

Also, the prior addition of vdprintf() in v20241026 neglected to close
the related tickets:

Closes: #67598
Closes: #70118

TESTED:
Tested both normal and -devel versions -/+universal on 10.4-10.5 ppc,
10.5-10.6 ppc (i386 Rosetta), 10.4-10.6 i386, 10.4-12.x x86_64, and
11.x-15.x arm64.
Builds and passes all tests on all tested platforms.

comment:4 Changed 12 months ago by fhgwright (Fred Wright)

In a784d15ced04e75724ee259cec1f7a3d1ab696d3/macports-ports (master):

legacy-support: update to v1.4.0.

Notable changes since v1.3.0:

  • Works around Apple's broken versioning in the macOS 15 SDK
  • Implements scandir() compatibility feature
  • Fixes dprintf() bug and implements vdprintf() See: #67598 See: #70118
  • Mismatched SDK compatibility is extended to include 15.x SDK.
  • Broken 10.4 CLOCK_MONOTONIC is fixed.
  • Fixes stat inconsistency in some 32-bit 10.4 builds.
  • Adds stat64 header support for 10.4 SDK.
  • Adds INODE64 support for *stat*() on 10.4.
  • Reworks fstatat*() support, similar to previous item, fixing buffer overrun in some cases.
  • Backports 10.5 'which' to 10.4.
  • Adds support for code that can't tolerate the normal scandir() compatibility feature.
  • Replaces broken 10.4/10.5 copyfile wrapper with full 10.6 copyfile.
  • Extends 10.4 INODE64 support to *statx_np() functions.
  • Expands TARGET_* defaults. See: #70824
  • Fixes 10.4 Rosetta bug in fstatx_np()
  • Makes renameat() available via stdio.h See: #71842
  • Implements interim clock_gettime_nsec_np() See: #61691
  • Implements clock_settime() See: #71399
  • Adds net/if_tun.h for <10.6 See: #70231
  • Provides pthread_[f]chdir_np() for 10.5+ See: #71265
  • Adds CPU_TYPE_ARM definition for 10.4 See: #71621

TESTED:
Tested both normal and -devel versions -/+universal on 10.4-10.5 ppc,
10.5-10.6 ppc (i386 Rosetta), 10.4-10.6 i386, 10.4-12.x x86_64, and
11.x-15.x arm64.
Builds and passes all tests on all tested platforms.

comment:5 Changed 10 months ago by mascguy (Christopher Nielsen)

Component: portslegacy-support

Recategorize existing legacy-support lib tickets, to use new component definition.

Note: See TracTickets for help on using tickets.