poppler: fails to build due to obsolete gcc patches

[rmottola (Riccardo)]

On Leopard PPC, poppler fails to build:

patching file cmake/modules/PopplerMacros.cmake
--->  Applying patch-glib_CMakeFiles.txt-fix-include-ordering.diff
Executing:  cd "/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0" && /usr/bin/patch -t -N -p0 < '/Users/multix/code/macports-leopard/graphics/poppler/files/patch-glib_CMakeFiles.txt-fix-include-ordering.diff'
patching file glib/CMakeLists.txt
Hunk #1 succeeded at 121 (offset 4 lines).
Hunk #2 succeeded at 133 (offset 4 lines).
--->  Applying patch-poppler-gcc7-noexcept.diff
Executing:  cd "/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0" && /usr/bin/patch -t -N -p0 < '/Users/multix/code/macports-leopard/graphics/poppler/files/patch-poppler-gcc7-noexcept.diff'
patching file poppler/GfxFont.cc
Hunk #1 succeeded at 181 (offset 1 line).
patching file poppler/GfxFont.h
patching file poppler/CertificateInfo.cc
Hunk #1 FAILED at 39.
1 out of 1 hunk FAILED -- saving rejects to file poppler/CertificateInfo.cc.rej
patching file poppler/CertificateInfo.h
Hunk #1 FAILED at 70.
1 out of 1 hunk FAILED -- saving rejects to file poppler/CertificateInfo.h.rej
Command failed:  cd "/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0" && /usr/bin/patch -t -N -p0 < '/Users/multix/code/macports-leopard/graphics/poppler/files/patch-poppler-gcc7-noexcept.diff'
Exit code: 1
Error: Failed to patch poppler: command execution failed

[rmottola (Riccardo)]

I tried removing the patch-poppler-gcc7-noexcept.diff from the portfile. It then fails

/opt/local/bin/g++-mp-7 -Dpoppler_EXPORTS -I/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0 -I/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/fofi -I/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/goo -I/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/poppler -I/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/build -I/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/build/poppler -isystem /opt/local/include/openjpeg-2.5 -isystem /opt/local/include -isystem /opt/local/include/freetype2 -isystem /opt/local/include/nss -isystem /opt/local/include/nspr -isystem /opt/local/include/gpgme++ -isystem /opt/local/libexec/boost/1.76/include -Wall -Wextra -Wpedantic -Wno-unused-parameter -Wcast-align -Wformat-security -Wframe-larger-than=65536 -Wlogical-op -Wmissing-format-attribute -Wnon-virtual-dtor -Woverloaded-virtual -Wmissing-declarations -Wundef -Wzero-as-null-pointer-constant -Wshadow -Wsuggest-override -fno-exceptions -fno-check-new -fno-common -fno-operator-names -D_DEFAULT_SOURCE -O2 -g -pipe -I/opt/local/libexec/boost/1.76/include -Os -DNDEBUG -I/opt/local/libexec/boost/1.76/include -isystem/opt/local/include/LegacySupport -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++1z -arch ppc -mmacosx-version-min=10.5 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT CMakeFiles/poppler.dir/poppler/GfxFont.cc.o -MF CMakeFiles/poppler.dir/poppler/GfxFont.cc.o.d -o CMakeFiles/poppler.dir/poppler/GfxFont.cc.o -c /opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/poppler/GfxFont.cc
/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/poppler/GfxFont.cc:184:13: error: function 'GfxFontLoc& GfxFontLoc::operator=(GfxFontLoc&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ''
 GfxFontLoc &GfxFontLoc::operator=(GfxFontLoc &&other) noexcept = default;
             ^~~~~~~~~~
/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/poppler/GfxFont.cc: In member function 'std::optional<GfxFontLoc> GfxFont::locateFont(XRef*, PSOutputDev*, GooString*)':
/opt/local/var/macports/build/_Users_multix_code_macports-leopard_graphics_poppler/poppler/work/poppler-23.11.0/poppler/GfxFont.cc:680:24: error: could not convert 'fontLoc' from 'GfxFontLoc' to 'std::optional<GfxFontLoc>'
                 return fontLoc;
                        ^~~~~~~

which tells.. noexcept is needed...

[reneeotten (Renee Otten)]

Feel free to fix the patch(es) and submit a PR.