Opened 6 months ago

Closed 2 weeks ago

#71458 closed defect (fixed)

FreeRDP: Broken on Sequoia

Reported by: DanielO (Daniel O'Connor) Owned by: thestr4ng3r (Florian Märkl)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: FreeRDP

Description (last modified by DanielO (Daniel O'Connor))

As per this bug: https://github.com/FreeRDP/FreeRDP/issues/10558

It seems unlikely it will be fixed so at least for Sequoia a work around is to build xfreerdp.

The attached patch does this (and updates to 3.9.0). The patch file is no longer necessary.

Attachments (1)

freerdp-3.9.0.diff (3.0 KB) - added by DanielO (Daniel O'Connor) 6 months ago.

Download all attachments as: .zip

Change History (5)

Changed 6 months ago by DanielO (Daniel O'Connor)

Attachment: freerdp-3.9.0.diff added

comment:1 Changed 6 months ago by DanielO (Daniel O'Connor)

Description: modified (diff)

comment:2 Changed 6 months ago by ryandesign (Ryan Carsten Schmidt)

Summary: net/FreeRDP: Broken on SequoiaFreeRDP: Broken on Sequoia

Since you are increasing the version, the revision should be set to 0.

Since you are switching from the Mac-native client to the X implementation, I wonder if the block starting with the comment # AVAudioBuffer was introduced in OS X 10.10 is still applicable.

It's easier to review changes and to verify that your changes build correctly if you submit a pull request.

comment:3 Changed 5 months ago by DanielO (Daniel O'Connor)

Sorry, took me a while to get around to it - done! https://github.com/macports/macports-ports/pull/27098

comment:4 Changed 2 weeks ago by thestr4ng3r (Florian Märkl)

Owner: set to thestr4ng3r
Resolution: fixed
Status: newclosed

In 7eaf80ee5cd6b35f51b5ea93c82452c115dc9c6b/macports-ports (master):

FreeRDP: update to 3.15.0

  • server disabled unconditionally and mac client made a non-default variant to fix build on macOS > 14
  • added variants for sdl2 and sdl3 (default) to replace mac client

See also https://github.com/FreeRDP/FreeRDP/issues/10558 for reference

Closes: #71458

Note: See TracTickets for help on using tickets.