Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#71630 closed defect (fixed)

TeXShop @5.48_0 fails to build: patch fails to apply

Reported by: msrski59 Owned by: Schamschula (Marius Schamschula)
Priority: Normal Milestone:
Component: ports Version: 2.10.5
Keywords: Monterey Cc:
Port: TeXShop

Description

TeXShop @5.48_0 fails to build on Monterey 12.7.6 with Xcode 14.2 (Build 14C18)

The build fails because a patch fails to apply:

Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_TeXShop/TeXShop/work/TeXShop-5.48" && /usr/bin/patch -t -N -p0 < '/opt/local/var/macports/sources/rsync.macports.org/macports/release/tarballs/ports/aqua/TeXShop/files/patch-Sources-TSTextView.m.diff'
Exit code: 1
Error: Failed to patch TeXShop: command execution failed

Log attached.

Attachments (2)

main.log (12.4 KB) - added by msrski59 7 months ago.
TSTextView.m.rej (780 bytes) - added by msrski59 7 months ago.

Download all attachments as: .zip

Change History (11)

Changed 7 months ago by msrski59

Attachment: main.log added

comment:1 Changed 7 months ago by jmroot (Joshua Root)

Cc: mps@… removed
Owner: set to Schamschula
Status: newassigned

comment:2 Changed 7 months ago by Schamschula (Marius Schamschula)

This patch has been a problem. I thought I had fixed it.

Last edited 7 months ago by Schamschula (Marius Schamschula) (previous) (diff)

comment:3 Changed 7 months ago by Schamschula (Marius Schamschula)

The patch applies correctly on my build machine. I'm not sure what is going on.

Note: I'm on Sonoma, but that's using the same version of TeXShop.

Last edited 7 months ago by Schamschula (Marius Schamschula) (previous) (diff)

comment:4 Changed 7 months ago by Schamschula (Marius Schamschula)

Can you please attach the TSTextView.m.rej file?

comment:5 Changed 7 months ago by msrski59

I'd be happy to attach the file. Where is it?

I just cleaned TeXShop and tried to rebuild, generating the same failure. Searching with mdfind for that file comes up blank.

comment:6 Changed 7 months ago by msrski59

I just tried to upgrade TeXShop from 5.47_0 to 5.48_0 on my laptop.

Sequoia 15.2 with Xcode 16.2 (Build 16C5032a) and MacPorts 2.10.5

The build fails with a failure to patch. Seems like the identical issue. Also cannot find the TSTextView.m.rej file that you are asking for.

Changed 7 months ago by msrski59

Attachment: TSTextView.m.rej added

comment:7 Changed 7 months ago by msrski59

Apologies, I'm a user, not a hacker. I found the TSTextView.m.rej file from the Monterey build failure and have attached it.

comment:8 Changed 7 months ago by Marius Schamschula <mschamschula@…>

Resolution: fixed
Status: assignedclosed

In b89302ba8f9b18ab7120f7760f8c3f230141b41b/macports-ports (master):

TeXShop: fix patch-Sources-TSTextView.m.diff

Closes: #71630

comment:9 Changed 7 months ago by msrski59

For anyone who experiences this failure, the patch fix allows the patch to apply, but TeXShop @5.48_0 still fails to build on Monterey.

See ticket #71643

Last edited 7 months ago by msrski59 (previous) (diff)
Note: See TracTickets for help on using tickets.