Opened 19 months ago

Closed 19 months ago

Last modified 18 months ago

#71904 closed enhancement (fixed)

gdal @3.10.1: mention +kea variant creating a circular dependency in the variant description

Reported by: cooljeanius (Eric Gallager) Owned by: nilason (Nicklas Larsson)
Priority: Normal Milestone:
Component: ports Version: 2.10.5
Keywords: Cc: Veence (Vincent), nilason (Nicklas Larsson)
Port: gdal

Description (last modified by cooljeanius (Eric Gallager))

gdal's +kea variant description currently reads:

kea: Enable KEA support

However, one thing to note about this variant is that it creates a circular dependency, as kealib depends on gdal, yet the variant description says nothing about this. Compare this to, for example, dbus's +tests variant, which also involves a circular dependency:

# XXX Building with tests enabled causes dbus to link with dbus-glib,
# which it shouldn't do because that port depends on this one: see #30088
variant test description {enable tests (Only Works if dbus is Already Installed)} {
    ui_warn "This variant requires circular dependencies and only works if ${name} is already installed"

    configure.args-replace  --disable-tests \
                            --enable-tests
    configure.args-append   --without-dbus-glib
    depends_build-append    path:lib/pkgconfig/glib-2.0.pc:glib2
    depends_build-append    port:python27 port:dbus-python27 port:py27-gobject3 port:dbus-python
    configure.python        ${prefix}/bin/python2.7
}

It would be nice if gdal's +kea variant could be updated to provide a similar note about circular dependencies.

Change History (6)

comment:1 Changed 19 months ago by cooljeanius (Eric Gallager)

Description: modified (diff)

comment:2 Changed 19 months ago by nilason (Nicklas Larsson)

Ideally, it should be implemented as gdal subport: gdal-kea. I’ll see if that is feasible.

comment:3 Changed 19 months ago by nilason (Nicklas Larsson)

In dad4921aedaf93c23a5dc928851bb36f86a87a33/macports-ports (master):

gdal: add subport 'gdal-kea', replacing the 'kea' variant

See: #71904

comment:4 Changed 19 months ago by nilason (Nicklas Larsson)

Owner: set to nilason
Resolution: fixed
Status: newclosed

In 41ab62ddee164131990b009b686696a15da92197/macports-ports (master):

kealib: drop unnecessary dependency on 'gdal'

Closes: #71904

comment:5 in reply to:  3 ; Changed 18 months ago by cooljeanius (Eric Gallager)

Replying to nilason:

In dad4921aedaf93c23a5dc928851bb36f86a87a33/macports-ports (master):

gdal: add subport 'gdal-kea', replacing the 'kea' variant

See: #71904

I noticed a copy-paste mistake in this; please check the references to hdf4 to ensure they match the variant in question

comment:6 in reply to:  5 Changed 18 months ago by nilason (Nicklas Larsson)

Replying to cooljeanius:

Replying to nilason:

In dad4921aedaf93c23a5dc928851bb36f86a87a33/macports-ports (master):

gdal: add subport 'gdal-kea', replacing the 'kea' variant

See: #71904

I noticed a copy-paste mistake in this; please check the references to hdf4 to ensure they match the variant in question

Thanks, I’ll fix it as soon as possible.

Note: See TracTickets for help on using tickets.