#72760 closed defect (fixed)
macportsbot isn't assigning PRs to maintainers
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | admin@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | server/hosting | Version: | |
| Keywords: | Cc: | ||
| Port: |
Description
macportsbot isn't assigning PRs to maintainers:
- https://github.com/macports/macports-ports/pull/29025
- https://github.com/macports/macports-ports/pull/29027
- https://github.com/macports/macports-ports/pull/29028
However it did do this one:
Change History (4)
comment:1 Changed 7 months ago by jmroot (Joshua Root)
comment:2 Changed 7 months ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The root cause was indeed again heavy bot traffic hitting braeburn leading to timeouts.
The good news is that I have now finished a script that will redeliver failed webhooks. I have not yet automatically deployed that anywhere, though, so for now I will have to run it manually from time to time.
comment:3 follow-up: 4 Changed 7 months ago by ryandesign (Ryan Carsten Schmidt)
Could I get a copy of that script? I could use it when I need to redeliver buildbot webhooks.
What I've learned from buildbot is that a webhook delivery classified as failed didn't necessarily fail; the server just didn't respond within the amount of time that github waited. On buildbot the consequence is minimal, but for Trac, the consequence is that comments can be posted repeatedly.
comment:4 Changed 7 months ago by neverpanic (Clemens Lang)
Replying to ryandesign:
Could I get a copy of that script? I could use it when I need to redeliver buildbot webhooks.
I set it up to re-deliver all webhooks we have set up.
What I've learned from buildbot is that a webhook delivery classified as failed didn't necessarily fail; the server just didn't respond within the amount of time that github waited. On buildbot the consequence is minimal, but for Trac, the consequence is that comments can be posted repeatedly.
That's unfortunate, but probably needs to be solved on the Trac end. If all else fails, by keeping a record of the uuid of the notifications that we have processed.
I've pushed a copy at https://github.com/neverpanic/macports-webhook-redelivery.
The webhooks are (or were) failing to deliver, probably due to heavy load on braeburn.