fizz @2024.09.23.00_4: compilation error for extensions/delegatedcred/Serialization.cpp

[tjhart (Tim Hart)]

This was discovered while trying to install the watchman port (@2023.11.13.00_6) on a brand new macOS 26 box.

:info:build [46/103] /usr/bin/clang++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LI
NK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -Dfizz_EXPORTS -I/opt/local/var/macports/build/fizz-ce51599c/work/fizz-v2024.09.23.00 -I/opt/local/var/macports/build/fiz
z-ce51599c/work/build/generated -isystem /opt/local/include -isystem /opt/local/libexec/openssl3/include -isystem /opt/local/libexec/boost/1.81/include -isystem /opt/local/include/libfmt11 -isystem /opt/local/include/oqs -pipe -I/opt/local/libexec/openssl3/include -I/op
t/local/libexec/boost/1.81/include -Os -DNDEBUG -I/opt/local/libexec/openssl3/include -I/opt/local/libexec/boost/1.81/include -isystem/opt/local/include -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX26.sdk -std=c++17 -arch arm64 -isysroot /Libra
ry/Developer/CommandLineTools/SDKs/MacOSX26.sdk -mmacosx-version-min=26.0 -fPIC -MD -MT CMakeFiles/fizz.dir/extensions/delegatedcred/Serialization.cpp.o -MF CMakeFiles/fizz.dir/extensions/delegatedcred/Serialization.cpp.o.d -o CMakeFiles/fizz.dir/extensions/delegatedcre
d/Serialization.cpp.o -c /opt/local/var/macports/build/fizz-ce51599c/work/fizz-v2024.09.23.00/fizz/extensions/delegatedcred/Serialization.cpp
:info:build FAILED: [code=1] CMakeFiles/fizz.dir/extensions/delegatedcred/Serialization.cpp.o 
:info:build /usr/bin/clang++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOS
T_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -Dfizz_EXPORTS -I/opt/local/var/macports/build/fizz-ce51599c/work/fizz-v2024.09.23.00 -I/opt/local/var/macports/build/fizz-ce51599
c/work/build/generated -isystem /opt/local/include -isystem /opt/local/libexec/openssl3/include -isystem /opt/local/libexec/boost/1.81/include -isystem /opt/local/include/libfmt11 -isystem /opt/local/include/oqs -pipe -I/opt/local/libexec/openssl3/include -I/opt/local/l
ibexec/boost/1.81/include -Os -DNDEBUG -I/opt/local/libexec/openssl3/include -I/opt/local/libexec/boost/1.81/include -isystem/opt/local/include -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX26.sdk -std=c++17 -arch arm64 -isysroot /Library/Develo
per/CommandLineTools/SDKs/MacOSX26.sdk -mmacosx-version-min=26.0 -fPIC -MD -MT CMakeFiles/fizz.dir/extensions/delegatedcred/Serialization.cpp.o -MF CMakeFiles/fizz.dir/extensions/delegatedcred/Serialization.cpp.o.d -o CMakeFiles/fizz.dir/extensions/delegatedcred/Seriali
zation.cpp.o -c /opt/local/var/macports/build/fizz-ce51599c/work/fizz-v2024.09.23.00/fizz/extensions/delegatedcred/Serialization.cpp
:info:build In file included from /opt/local/var/macports/build/fizz-ce51599c/work/fizz-v2024.09.23.00/fizz/extensions/delegatedcred/Serialization.cpp:12:
:info:build In file included from /opt/local/include/folly/base64.h:29:
:info:build /opt/local/include/folly/memory/UninitializedMemoryHacks.h:312:8: error: no template named '__compressed_pair' in namespace 'std'
:info:build   312 |   std::__compressed_pair<pointer, allocator_type> __end_cap_;
:info:build       |   ~~~~~^
:info:build 1 error generated.

[tjhart (Tim Hart)]

build log

[barracuda156]

Replying to tjhart:

Here is the fix, apparently: ​https://github.com/facebook/folly/commit/ef5160f6b02fb8eb971adf7edd3aea96ef73bc66 Referred from ​https://bugs.gentoo.org/951832

[barracuda156]

Please update on whether this works.

[ryandesign (Ryan Carsten Schmidt)]

That fix went into folly 2025.04.07.00 so we should just update this collection of related ports to at least that version.

[barracuda156]

Replying to ryandesign:

That fix went into folly 2025.04.07.00 so we should just update this collection of related ports to at least that version.

You could borrow updated ports from ​here (I currently have 2025.08.25 versions), however I do not update edencommon and watchman, so someone has to deal with those, if the whole set will be updated.

16. S. While there is no requirement for all versions to strictly match, I don’t think 2023 ones will work with 2025 ones.