Opened 9 months ago

Closed 6 months ago

#73166 closed defect (fixed)

cgal4: openscad and other ports depending on cgal4 fail to build

Reported by: tmladek (Tomáš Mládek) Owned by: veence
Priority: Normal Milestone:
Component: ports Version:
Keywords: tahoe Cc: dstrubbe (David Strubbe), thomasrussellmurphy (Thomas Russell Murphy), Dave-Allured (Dave Allured)
Port: cgal4 openscad

Description

I'm using the latest MacPorts version, I tried port cleaning the port and trying to reinstall, but it still fails to build. In the log I was pointed to (/opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_openscad/openscad/main.log), I found at least the following errors (repeated a few times):

// ...snip...
:info:build In file included from src/CGAL_Nef_polyhedron.h:4:
:info:build In file included from src/cgal.h:15:
:info:build In file included from /opt/local/include/CGAL/Nef_polyhedron_2.h:32:
:info:build In file included from /opt/local/include/CGAL/HalfedgeDS_default.h:32:
:info:build In file included from /opt/local/include/CGAL/boost/graph/graph_traits_HalfedgeDS_default.h:24:
:info:build In file included from /opt/local/include/CGAL/boost/graph/graph_traits_HalfedgeDS.h:38:
:info:build /opt/local/include/CGAL/boost/graph/iterator.h:233:22: error: no member named 'base' in 'Halfedge_around_source_iterator<Graph>'
:info:build   233 |     return (! (this->base() == NULL)) ?
:info:build       |                ~~~~  ^
:info:build /opt/local/include/CGAL/boost/graph/iterator.h:333:22: error: no member named 'base' in 'Halfedge_around_target_iterator<Graph>'
:info:build   333 |     return (! (this->base() == NULL)) ?
:info:build       |                ~~~~  ^
:info:build /opt/local/include/CGAL/boost/graph/iterator.h:432:22: error: no member named 'base' in 'Halfedge_around_face_iterator<Graph>'
:info:build   432 |     return (! (this->base() == NULL)) ?
:info:build       |                ~~~~  ^

It looks like this issue could be related: https://github.com/CGAL/cgal/issues/8313 and so it could be an issue with cgal, but the health of the cgal4 port seems to be fine on Tahoe/arm64, whereas the openscad port seems to fail currently: https://build.macports.org/builders/ports-26_arm64-builder/builds/15492

I'm completely new to MacPorts and I don't have too much visibility into openscad's build process so some of this might be off, but this is as far as I got. Thanks in advance!

Change History (7)

comment:1 Changed 9 months ago by jmroot (Joshua Root)

Owner: set to dstrubbe
Port: openscad added
Status: newassigned

comment:2 in reply to:  description Changed 9 months ago by ryandesign (Ryan Carsten Schmidt)

Cc: dstrubbe added
Keywords: tahoe added
Owner: changed from dstrubbe to veence
Port: cgal4 added
Summary: openscad 2021.01 fails to build on Tahoe (arm64)cgal4: openscad and other ports depending on cgal4 fail to build

Replying to tmladek:

It looks like this issue could be related: https://github.com/CGAL/cgal/issues/8313

I think you're exactly right. The fix for that issue needs to be added to our cgal4 port. (Upstream only fixed it for cgal 5.5 and later.)

comment:3 Changed 7 months ago by thomasrussellmurphy (Thomas Russell Murphy)

Cc: thomasrussellmurphy added

comment:4 Changed 7 months ago by Dave-Allured (Dave Allured)

Cc: Dave-Allured added

comment:5 Changed 7 months ago by Dave-Allured (Dave Allured)

Backported that fix. Patch submitted in PR 30547. Please test.

comment:6 Changed 6 months ago by DanielO (Daniel O'Connor)

I just tested this patch and it works - I can build openscad and it runs fine.

Thanks Dave!

comment:7 Changed 6 months ago by Dave-Allured (Dave Allured)

Resolution: fixed
Status: assignedclosed

In db13acaa9a5a7746c76c393b1dc438390238d514/macports-ports (master):

cgal4: Fix build problem for dependents (https://github.com/macports/macports-ports/pull/30547)

  • cgal4: Fix build problem for dependents

Backport a compile fix from CGAL 5.5.5 to CGAL 4.14, which fixes a build problem for dependent ports.
Fixes "error: no member named 'base' in 'Halfedge_around_source_iterator

Closes #73166

Note: See TracTickets for help on using tickets.