expat @2.8.1 does not build on PPC Leopard, Mac OS X 10.5.8, because of error: 'O_CLOEXEC' undeclared (first use in this function)

[ballapete (Peter "Pete" Dyballa)]

/bin/sh ../libtool  --tag=CC   --mode=compile /usr/bin/gcc-4.2 -std=gnu99 -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include -Wall -Wextra -fexceptions -Wstrict-aliasing=3 -Wmissing-prototypes -Wstrict-prototypes -pedantic -Wshadow -Wformat=2 -pipe -Os -arch ppc -MT random_dev_urandom.lo -MD -MP -MF .deps/random_dev_urandom.Tpo -c -o random_dev_urandom.lo random_dev_urandom.c
libtool: compile:  /usr/bin/gcc-4.2 -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include -Wall -Wextra -fexceptions -Wstrict-aliasing=3 -Wmissing-prototypes -Wstrict-prototypes -pedantic -Wshadow -Wformat=2 -pipe -Os -arch ppc -MT random_dev_urandom.lo -MD -MP -MF .deps/random_dev_urandom.Tpo -c random_dev_urandom.c  -fno-common -DPIC -o .libs/random_dev_urandom.o
random_dev_urandom.c: In function 'writeRandomBytes_dev_urandom':
random_dev_urandom.c:50: error: 'O_CLOEXEC' undeclared (first use in this function)
random_dev_urandom.c:50: error: (Each undeclared identifier is reported only once
random_dev_urandom.c:50: error: for each function it appears in.)
make[2]: *** [random_dev_urandom.lo] Error 1
make[2]: Leaving directory `/opt/local/var/macports/build/expat-e9b9624d/work/expat-2.8.1/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/expat-e9b9624d/work/expat-2.8.1'
make: *** [all] Error 2

LegacySupport should have it…

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Leopard, Mac OS X 10.5.8

[jmroot (Joshua Root)]

In 63bfbc0e0109bd6ddec3b0bd04d6a3750666e643/macports-ports (master):

expat: fix build on systems without O_CLOEXEC

Closes: #74045

[ryandesign (Ryan Carsten Schmidt)]

Thanks, I filed a bug report: ​https://github.com/libexpat/libexpat/issues/1250

[jmroot (Joshua Root)]

I considered taking this upstream, but the discussion around the change that caused this suggested that they would not be receptive.

[ryandesign (Ryan Carsten Schmidt)]

I'm not aware of that discussion, but indeed the developer did decline to fix the bug.

The reason I submitted it upstream, aside from my usual desire to send changes upstream, is that every time a new version of expat is released, I receive an email notification from the developer which contains the explicit request for us to share any patches with them. I'll ask them to adjust the wording of that request.