Opened 18 years ago

Closed 17 years ago

#7574 closed enhancement (fixed)

UPDATE: VTK-4.2.6 add install_name support

Reported by: cssdev@… Owned by: cssdev
Priority: Normal Milestone:
Component: ports Version: 1.2
Keywords: Cc: johans@…
Port:

Description

The attached Portfile patch updates the VTK port to specify the correct install_name. This feature is only provided by the cmake-devel port, but older versions of CMake will simply ignore the new options. I don't think this warrants a variant, as the need for install_name support is not essential due to the an workaround with DYLD_FALLBACK_LIBRARY_PATH.

Because this feature is only available through the cmake-devel port at this time, it's possible to install that port before building VTK. However, I don't want to force a dependency on a devel port. Should I simply update the Portfile and provide a message that people requiring install_name support should install cmake-devel first?

See BUG #4495 and BUG #7571.

Attachments (3)

patch-Portfile.diff (843 bytes) - added by cssdev@… 18 years ago.
vtk Portfile patch
patch-Portfile.2.diff (1021 bytes) - added by cssdev@… 18 years ago.
vtk Portfile patch
patch-Portfile.3.diff (872 bytes) - added by cssdev 17 years ago.
Set verbose compiling and libraries' install_names

Download all attachments as: .zip

Change History (13)

Changed 18 years ago by cssdev@…

Attachment: patch-Portfile.diff added

vtk Portfile patch

comment:1 Changed 18 years ago by cssdev@…

blocked: 4495

comment:2 Changed 18 years ago by cssdev@…

Cc: johans@… added

It just occurred to me that older versions of CMake will still include the incorrect path using the build directory. If cmake-devel is installed, then the VTK port should use the new features available. Otherwise, it should completely exclude rpath support.

Maybe the Portfile can parse the output from 'cmake --version' to determine the currently installed version of CMake? That gets ugly, as the alternative is to strictly depend on the cmake-devel port. Perhaps a variant could rely on cmake-devel with the updated install_names, while the default could rely on the stable version of cmake without install_names (relying instead on DLYD_LIBRARY_PATH)?

comment:3 Changed 18 years ago by cssdev@…

dependson: 9036

Changed 18 years ago by cssdev@…

Attachment: patch-Portfile.2.diff added

vtk Portfile patch

comment:4 Changed 18 years ago by cssdev@…

attachments.isobsolete: 01

comment:5 Changed 18 years ago by cssdev@…

Summary: RFC: vtk install_name support via cmake-develUPDATE: VTK-4.2.6 add install_name support

Changed bug title to reflect that this issue may now be resorted with an update to the VTK Portfile.

comment:6 Changed 18 years ago by markd@…

Type: defectenhancement

comment:7 Changed 18 years ago by cssdev

Owner: changed from macports-tickets@… to css@…

Reassign to maintainer.

comment:8 Changed 18 years ago by cssdev

Component: dp-cocoaports
Status: newassigned

Changed 17 years ago by cssdev

Attachment: patch-Portfile.3.diff added

Set verbose compiling and libraries' install_names

comment:9 Changed 17 years ago by cssdev

CMake usually hides the compile commands, and that can make debugging with port -v build challenging. The latest patch simply sets CMake to verbose mode in addition to setting the required flags for rpath/install_name support.

comment:10 Changed 17 years ago by cssdev

Resolution: fixed
Status: assignedclosed

Fixed in r19880.

Note: See TracTickets for help on using tickets.