Changes between Version 21 and Version 22 of NewCommittersGuide

Timestamp:

Apr 1, 2010, 2:46:02 PM (14 years ago)

Author:

raimue (Rainer Müller)

Comment:

Clarify rules, allow combined updates affecting similar ports

NewCommittersGuide

@@ -5 +5 @@
 == Port Committer Responsibilities ==
 
- 1. PortIndex is now updated automatically (every hour) so it must not be touched
- 1. A commit affects one port (including however many files are required for that one port)
- 1. The exception to the one port/one commit rule is where several Portfiles make use of some feature which is in need of updating
-   1. Due to a new feature which has been added to the current release to fix hacks used by various Portfiles
-   1. A command is found to be broken
-   1. You need to change your email address for your ports
+ 1. Do not touch PortIndex. It is updated automatically every hour
+ 1. A commit affects one port
+ 1. An exception to 2. would be several Portfiles making use of some feature which requires an update
+   1. A new feature has been released which obsoletes previous hacks
+   1. A command or option is found to be broken
+   1. Combined updates for similar ports (py25-* and py26-*)
+   1. Changing maintainer email address for your ports
    1. Other, similar reasons
- 1. When changing the whitespace of a Portfile, do so in a separate commit (without any functional changes) as otherwise the commingling of functional and whitespace changes makes reviewing diffs difficult
+ 1. Make whitespace changes in a separate commit. To keep diffs readable for review whitespace changes should be done in a separate commit without any functional changes.
  1. New top-level categories (those which are represented by subdirectories directly beneath dports/) need to be approved prior to adding; secondary categories (the second and later ones listed on the '''categories''' Portfile key) can be added when it makes sense (since these really only show under the web interface, and do not necessarily have a filesystem representation)
  1. Make sure the port name matches between the MacPorts svn directory name and the '''name''' Portfile key (while the system works fine when they don't, keeping them synchronized avoids confusing situations)