BUG: calc 2.12.1.5 doesn't build (malloc.h: No such file or directory)

[vinc17@…]

I get the following error:

gcc  -DCALC_SRC -Wall -W -Wno-comment -O3 -g3     -c -o addop.o addop.c
In file included from zmath.h:43,
                 from qmath.h:36,
                 from cmath.h:36,
                 from value.h:37,
                 from calc.h:37,
                 from addop.c:34:
alloc.h:48:21: error: malloc.h: No such file or directory
make: *** [addop.o] Error 1

Moreover, I assume that the maintainer address @opendarwin.org is out-of-date.

[vinc17@…]

New files/patch-Makefile that fixes the bug

[vinc17@…]

Hmm... I see that my patch adds a dependency on the cgilib port (which doesn't do the right thing by providing /opt/local/include/malloc.h -- IMHO this file should be in the base or all references to <malloc.h> should be removed).

[cssdev]

The file malloc.h is not supported in Mac OS X. Source code should use stdlib.h instead.

See ​TN2071 Porting Command Line Unix Tools to Mac OS X

[vinc17@…]

I've looked at the source very quickly, and in fact, the Makefile detects if the system provides a malloc.h or not. I don't know why (perhaps an inconsistency in the include paths and the fact that the cgilib port provides a malloc.h), but the test was failing without my patch. Alternatively, one can force HAVE_MALLOC_H to NO in the Makefile.

[markd@…]

Version 2.12.1.8 is out. Does that version ahve the same problem?

[vinc17@…]

No, but it has another problem:

Error: Target com.apple.archive returned: error copying "/opt/local/var/db/dports/build/_Users_vinc17_wd_macosx_dports_math_calc/work/.darwinports.calc.state" to "/opt/local/var/db/dports/build/_Users_vinc17_wd_macosx_dports_math_calc/work/destroot/+STATE": no such file or directory

[vinc17@…]

Oops, I took the wrong Portfile. 2.12.1.8 has the same problem.

[markd@…]

Looks like it needs some more patching.

​http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/math/calc/files/patch-alloc.h?rev=1.1&content-type=text/plain

Also, from the Makefile:

# For Apple: install fink from ​http://fink.sourceforge.net # and then do a 'fink install readline' and then use: # #READLINE_LIB= -L/sw/lib -lreadline -lhistory -lncurses

[vinc17@…]

Patch to upgrade to 2.12.1.8 and add readline support

[markd@…]

Ok, I committed a fix for cgilib that makes unnecessary the malloc.h dummy file. Does that fix this port or do you think the updates you attached are still necessary?

[vinc17@…]

The part concerning malloc.h is probably no longer necessary (the fact that the configure script detects a malloc.h which then can't be included is an upstream bug -- who knows if a malloc.h is installed somewhere else?), but the part that includes readline is necessary.

[markd@…]

Committed minus the malloc part of the patch. Thanks!

[(none)]

Milestone Port Bugs deleted