New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #11749 (closed enhancement: fixed)

Opened 5 years ago

Last modified 3 years ago

RFE: Better X11 support for FOX - configure patch

Reported by: afb@… Owned by: lyle.johnson@…
Priority: Low Milestone:
Component: ports Version:
Keywords: Cc: lyle.johnson@…, markd@…
Port:

Description

The configure script of fox-1.6.25 (and earlier) fails to detect some of the more advanced features on Apple's X11, due to a missing header in the configure script.

Attachments

patch-xlib-include Download (1.8 KB) - added by afb@… 5 years ago.
patch-xlib-include

Change History

Changed 5 years ago by afb@…

patch-xlib-include

Changed 5 years ago by afb@…

Portfile modification:

patchfiles          patch-xlib-include
use_autoconf        yes

Changed 5 years ago by pipping@…

  • milestone set to Port Enhancements

Changed 5 years ago by markd@…

  • cc lyle.johnson@…, markd@… added
  • owner changed from macports-dev@… to lyle.johnson@…

Assign to maintainer for approval of patch.

Changed 5 years ago by lyle.johnson@…

I am the maintainer, and I definitely approve this patch. Mark, can you (or another committer) go ahead and commit the patch? Or if there's some other action that I need to take first, please advise.

By the way, I have also submitted this patch directly to the FOX developers so that it can be incorporated into the main source repository. Hopefully, future updates to the port won't require this patch.

Changed 5 years ago by markd@…

  • status changed from new to closed
  • resolution set to fixed

All we need is your ok. So the patch is committed. Thanks!

Changed 5 years ago by afb@…

It was submitted upstream a few months before, though. (as noted in the patch itself too)  http://sourceforge.net/tracker/index.php?func=detail&aid=1663364&group_id=3372&atid=303372

Changed 5 years ago by afb@…

BTW: My main usage of FOX is for "xfe", as in Ticket #11750 (using Mac OS X to develop, then mostly used under Linux...)

Changed 5 years ago by markd@…

My understanding was that the patch contributed was sent upstream so I expect the patch can be removed for a future fox upgrade. Are you saying the patch applied in this ticket is not necessary now?

Changed 5 years ago by lyle.johnson@…

@markd: Sorry for the confusion. Anders (afb@…) was just pointing out that he's previously submitted this patch to the FOX developers but it was ignored. I have since resubmitted it and believe that it will be integrated soon. Once I have confirmation that that has happened, I will submit an update to the "fox" Portfile that removes the patch.

Changed 5 years ago by markd@…

Lyle, I see, no worries. Well its great that this stuff is going upstream. It takes time since sometimes you do get ignored, but it helps so much in the end. Thanks for clarifying.

Changed 5 years ago by nox@…

  • priority changed from Nice to have to Low
  • cc changed from lyle.johnson@gmail.com,markd@macports.org to lyle.johnson@gmail.com, markd@macports.org

Changed 3 years ago by anonymous

  • milestone Port Enhancements deleted

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.