BUG: Makefiles require GNU make

[afb@…]

The makefiles use some commands specific to GNU make, and don't work with BSD make.

[afb@…]

macports-bsdmake.patch

[jmpp@…]

Comments on the patch:

• For consistency's sake, would like to see a line like [ "$(ARC)" = "yes" ] && ${MAKE} SVNTAG=${DISTARCTAG} PKGNAME=${DISTARCNAME} _dopkg in base/Makefile.in rather than the one provided using test explicitly;
• Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;
• Not sure why we're exporting the deployment target in base/src/pextlib1.0 and in base/src/tclobjc1.0 and if removing the export keyword breaks anything, I'll let others chime in on that one.

Other than those three, the patch seems OK to me for inclusion.

-jmpp

[afb@…]

"Not sure if removing ifneq ($(MAKECMDGOALS),distclean) from base/doc/Makefile has any negative side effects, I haven't been able to spot any;"

Don't think it should have any, since doc/Makefile is processed before rm -f Mk/macports.autoconf.mk

[jmpp@…]

Milestone Needs developer review deleted

[tobypeterson]

Milestone MacPorts base bugs deleted

[cooljeanius (Eric Gallager)]

Cc Me!

[cooljeanius (Eric Gallager)]

The removal of the endifs would be useful not just for compatibility with BSD make, but also for people who might want to try converting the Makefiles to automake-generated ones: ​http://lists.gnu.org/archive/html/automake/2000-10/msg00107.html

[larryv (Lawrence Velázquez)]

Cc Me!