compile error with rdesktop 1.5.0

[jeb@…]

I'm getting the following error when I try to 'sudo port install rdesktop' - this is on a newish iMac with a clean working install of macports 1.50, I've previously installed apache2.2, php5, etc with this install.

---> Building rdesktop with target rdesktop Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_rdesktop/work/rdesktop-1.5.0" && make rdesktop " returned error 2 Command output: xwin.c: In function 'ui_seamless_ack': xwin.c:3675: error: 'sw' undeclared (first use in this function) xwin.c:3675: error: invalid operands to binary * xwin.c:3675: warning: statement with no effect xwin.c:3676: warning: statement with no effect xwin.c:3676: error: request for member 'next' in something not a structure or union xwin.c:3676: warning: statement with no effect xwin.c:3678: error: request for member 'outstanding_position' in something not a structure or union xwin.c:3678: error: request for member 'outpos_serial' in something not a structure or union xwin.c:3678: warning: comparison between pointer and integer xwin.c:3680: error: request for member 'xoffset' in something not a structure or union xwin.c:3680: error: request for member 'outpos_xoffset' in something not a structure or union xwin.c:3680: warning: statement with no effect xwin.c:3681: error: request for member 'yoffset' in something not a structure or union xwin.c:3681: error: request for member 'outpos_yoffset' in something not a structure or union xwin.c:3681: warning: statement with no effect xwin.c:3682: error: request for member 'width' in something not a structure or union xwin.c:3682: error: request for member 'outpos_width' in something not a structure or union xwin.c:3682: warning: statement with no effect xwin.c:3683: error: request for member 'height' in something not a structure or union xwin.c:3683: error: request for member 'outpos_height' in something not a structure or union xwin.c:3683: warning: statement with no effect xwin.c:3684: error: request for member 'outstanding_position' in something not a structure or union xwin.c:3684: warning: statement with no effect xwin.c:3690: error: request for member 'wnd' in something not a structure or union xwin.c:3691: error: request for member 'xoffset' in something not a structure or union xwin.c:3691: error: request for member 'yoffset' in something not a structure or union xwin.c:3691: error: request for member 'width' in something not a structure or union xwin.c:3691: error: request for member 'height' in something not a structure or union make: *** [xwin.o] Error 1

[ryandesign@…]

This error was also reported today on the mailing list by Frank Wilson.

I get a different error:

$ sudo port install rdesktop
--->  Fetching rdesktop
--->  Verifying checksum(s) for rdesktop
--->  Extracting rdesktop
--->  Configuring rdesktop
--->  Building rdesktop with target rdesktop
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_net_rdesktop/work/rdesktop-1.5.0" && make rdesktop " returned error 2
Command output: /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include  -I/usr/X11R6/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.5.0\" -DPACKAGE_STRING=\"rdesktop\ 1.5.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DL_ENDIAN=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST=const -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1  -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o cliprdr.o -c cliprdr.c
/usr/bin/gcc-4.0 -O2 -Wall -I/usr/include  -I/usr/X11R6/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.5.0\" -DPACKAGE_STRING=\"rdesktop\ 1.5.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DL_ENDIAN=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST=const -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1  -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o rdpsnd.o -c rdpsnd.c
/usr/bin/gcc-4.0 -O2 -Wall -I/usr/include  -I/usr/X11R6/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.5.0\" -DPACKAGE_STRING=\"rdesktop\ 1.5.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DL_ENDIAN=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST=const -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1  -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o rdpsnd_libao.o -c rdpsnd_libao.c
rdpsnd_libao.c:27:19: error: ao/ao.h: No such file or directory
rdpsnd_libao.c:35: error: parse error before '*' token
rdpsnd_libao.c:35: warning: type defaults to 'int' in declaration of 'o_device'
rdpsnd_libao.c:35: warning: data definition has no type or storage class
rdpsnd_libao.c: In function 'wave_out_open':
rdpsnd_libao.c:53: error: 'ao_sample_format' undeclared (first use in this function)
rdpsnd_libao.c:53: error: (Each undeclared identifier is reported only once
rdpsnd_libao.c:53: error: for each function it appears in.)
rdpsnd_libao.c:53: error: parse error before 'format'
rdpsnd_libao.c:55: warning: implicit declaration of function 'ao_initialize'
rdpsnd_libao.c:56: warning: implicit declaration of function 'ao_default_driver_id'
rdpsnd_libao.c:58: error: 'format' undeclared (first use in this function)
rdpsnd_libao.c:63: error: 'AO_FMT_LITTLE' undeclared (first use in this function)
rdpsnd_libao.c:65: warning: implicit declaration of function 'ao_open_live'
rdpsnd_libao.c:65: warning: assignment makes pointer from integer without a cast
rdpsnd_libao.c: In function 'wave_out_close':
rdpsnd_libao.c:91: warning: implicit declaration of function 'ao_close'
rdpsnd_libao.c:93: warning: implicit declaration of function 'ao_shutdown'
rdpsnd_libao.c: In function 'wave_out_set_format':
rdpsnd_libao.c:116: error: 'ao_sample_format' undeclared (first use in this function)
rdpsnd_libao.c:116: error: parse error before 'format'
rdpsnd_libao.c:118: error: 'format' undeclared (first use in this function)
rdpsnd_libao.c:123: error: 'AO_FMT_LITTLE' undeclared (first use in this function)
rdpsnd_libao.c:130: warning: assignment makes pointer from integer without a cast
rdpsnd_libao.c: In function 'wave_out_play':
rdpsnd_libao.c:243: warning: implicit declaration of function 'ao_play'
make: *** [rdpsnd_libao.o] Error 1

Error: Status 1 encountered during processing.
$

The port appears to be missing some dependencies. I patched the portfile and was able to make it install. Patch attached. Maintainers, please review this and let me know if it's ok to commit.

[ryandesign@…]

proposed fix

[cshbell@…]

The diff looks fine to me. Go ahead and commit.

[ryandesign@…]

Committed in r30586. Thanks!