Ticket #13799 (closed update: fixed)
Updated Logtalk portfile to version 2.31.1
| Reported by: | pmoura@… | Owned by: | ryandesign@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.6.0 |
| Keywords: | Cc: | ||
| Port: |
Description
Updated Logtalk portfile to version 2.31.1 (patch file).
Attachments
Change History
comment:1 Changed 5 years ago by ryandesign@…
- Cc ryandesign@… removed
- Owner changed from macports-tickets@… to ryandesign@…
comment:2 Changed 5 years ago by ryandesign@…
- Status changed from new to closed
- Resolution set to fixed
The attached patchfile does a number of different things, which I will commit in separate revisions:
- It changes some whitespace, which I committed in r33335.
- It adds the "universal_variant no" directive, which actually resolves a different ticket, #13694, so I handled it there.
- It updates the port to 2.31.1, and adds version numbers to the post-activate message, which I committed together in r33337, since I wasn't sure whether the newly-added version numbers in the post-activate phase were specific to the new version of logtalk.
- Lastly the patch undoes some changes I made in the destroot phase in r32262: It reintroduces the slash between ${destroot} and ${prefix} which doesn't really belong there, and it changes ${worksrcpath} back to ${workpath}/${worksrcdir} which is equivalent but unnecessarily more verbose. Did you really mean to make these changes? I'm guessing probably not so I didn't commit them.
Thanks for the update! It would be easier for me, though, if you would submit portfile patches that make just a single logical change so that I don't have to spend a lot of time separating each logical change out of a single monolithic patch. Thanks.
Note: See
TracTickets for help on using
tickets.

