base-1.6.0 "port uninstall" left installed files at case-sensitive FS

[ononon@…]

At HFS+ (case sensitive),

port install ncursesw
port uninstall ncursesw

make errors and some installed files are not deleted.

This is because "filemap" in Pextlib.dylib is a case-insensitive function, so

filemap set testmap "/A/Apple_Terminal" "casetest"
filemap set testmap "/a/appleII"        "casetest"
puts [filemap list testmap "casetest"]

show "/A/Apple_Terminal /A/appleII". (Note that path 'a' of 'appleII' was touppered !)

To fix this, you have only to substitute 'strncasecmp' with 'strncmp' in src/pextlib1.0/filemap.c . I guess that this fix make little influence to case-insensitive users, then expect that it is applied for our case-sensitive users.

Thanks in advance.

[jmr@…]

implementation of the requested change

[jmr@…]

The attached patch should do what you're asking for. Paul, you wrote this code—will this break anything?

[raimue@…]

Cc Me!

[jmr@…]

To answer my own question, yes, applying just this patch breaks deactivation.

[toby@…]

Milestone MacPorts base bugs deleted

[dhaines@…]

Cc Me!

[dhaines@…]

Replying to jmr@…:

To answer my own question, yes, applying just this patch breaks deactivation.

From what I can tell, replacing the three instances of strncasecmp in src/pextlib1.0/filemap.c with strncmp works just fine in 1.8.1. I've tested it on both a case-sensitive filesystem and a case-insensitive disk image, and it seems to handle activation, deactivation, installation, and deinstallation of various ports, including ncursesw and qt4-mac, just fine. Unless someone else finds an error with this, I'd ask that the change be included with the next released version of MacPorts.

[jmr@…]

Have you tested on Tiger, Leopard and Snow Leopard?

[dhaines@…]

Replying to jmr@…:

Have you tested on Tiger, Leopard and Snow Leopard?

Only Leopard. Sorry.

[dhaines@…]

Replying to dhaines@…:

Replying to jmr@…:

Have you tested on Tiger, Leopard and Snow Leopard?

Only Leopard. Sorry.

I've now tested on both Leopard and Snow Leopard, and the patch works on both.

[jmr@…]

r60246

[jmr@…]

Reverted in r60247, still breaks deactivation of some ports (e.g. ncursesw).

[ruud@…]

Cc Me!

[dhaines@…]

Replying to jmr@…:

Reverted in r60247, still breaks deactivation of some ports (e.g. ncursesw).

In which situations did it break things? I know that I tested it on 10.5, 10.6, both case sensitive and case insensitive. Is this a 10.4 issue? At worst, we could include an #ifdef for, say, 10.5 and 10.6. Thoughts?

[jmr@…]

Replying to dhaines@…:

In which situations did it break things?

Install without patch, apply patch, try deactivating.

[dhaines@…]

Replying to jmr@…:

Replying to dhaines@…:

In which situations did it break things?

Install without patch, apply patch, try deactivating.

Ah yes. I think that's just how any fix would have to be unless someone wants to write a migration/translation tool for the database affected.

[jmr@…]

This is probably fixed in the sqlite registry.

[jmr@…]

Seems fine to me, reopen if you still have this problem when using portdbformat sqlite.

[dhaines@…]

Replying to jmr@…:

Seems fine to me, reopen if you still have this problem when using portdbformat sqlite.

Isn't that an unsupported option?

[raimue@…]

Replying to dhaines@…:

Isn't that an unsupported option?

sqlite will be the new default registry format as of MacPorts 1.9. Please do not enable it yet with 1.8.x.