Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#14761 closed defect (fixed)

Cannot build proctools on Leopard

Reported by: akira@… Owned by: akira@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: leopard proctools kvm Cc: simmel@…
Port:

Description

--->  Building proctools with target all
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_Users_akira_src_dports_sysutils_proctools/work/proctools-0.4pre1" && bsdmake all " returned error 1
Command output: ===> proctools (all)
"/usr/share/mk/bsd.compat.mk", line 36: warning: NOLINT is deprecated in favor of NO_LINT
"/usr/share/mk/bsd.compat.mk", line 36: warning: NOPIC is deprecated in favor of NO_PIC
"/usr/share/mk/bsd.compat.mk", line 36: warning: NOPROFILE is deprecated in favor of NO_PROFILE
cc -Os -pipe    -c fmt.c
fmt.c:10:17: error: kvm.h: No such file or directory
fmt.c:32: error: syntax error before 'kvm_t'
fmt.c:32: warning: data definition has no type or storage class
fmt.c:34: error: syntax error before '{' token
fmt.c:37: error: syntax error before 'if'
fmt.c:43: error: syntax error before '\x20'
fmt.c:43: error: conflicting types for 'fmt_putc'
fmt.c:19: error: previous declaration of 'fmt_putc' was here
fmt.c:43: warning: data definition has no type or storage class
fmt.c:50: error: syntax error before '->' token
fmt.c:50: error: conflicting types for 'fmt_puts'
fmt.c:18: error: previous declaration of 'fmt_puts' was here
fmt.c:50: warning: data definition has no type or storage class
fmt.c:51: error: syntax error before ')'
fmt.c:51: error: conflicting types for 'fmt_putc'
fmt.c:19: error: previous declaration of 'fmt_putc' was here
fmt.c:51: warning: data definition has no type or storage class
*** Error code 1

Stop in /opt/local/var/macports/build/_Users_akira_src_dports_sysutils_proctools/work/proctools-0.4pre1/proctools.
*** Error code 1

Stop in /opt/local/var/macports/build/_Users_akira_src_dports_sysutils_proctools/work/proctools-0.4pre1.

Error: Status 1 encountered during processing.

Attachments (3)

proctools-leopard.patch (2.1 KB) - added by simmel@… 16 years ago.
proctools-leopard-without-104sdk.patch (5.4 KB) - added by simmel@… 16 years ago.
compile-leopard.patch (4.6 KB) - added by openspecies@… 16 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 16 years ago by akira@…

Keywords: kvm added
Status: newassigned

Leopard seems to dropped /dev/kmem. To get this working again, have to find out alternative to it.

comment:2 Changed 16 years ago by simmel@…

Hey akira,

I patched protools to work on Leopard but you need the 10.4 SDK installed. I've made some error handling about that within in Portfile but please feel free to modify it.

Changed 16 years ago by simmel@…

Attachment: proctools-leopard.patch added

comment:3 Changed 16 years ago by simmel@…

Cc: simmel@… added

Cc Me!

comment:4 Changed 16 years ago by akira@…

Hi simmel,

Thanks for your patch. I'm not sure whether the dependency on 10.4 SDK is a good option for this... Can you make it work on Leopard without it?

comment:5 Changed 16 years ago by simmel@…

Maybe if you hack the C-code, but I don't know C I'm afraid.

The reason why it's needed is because, if I understood it correctly, they removed /dev/kmem completely in Leopard.

While writing this message I started to hack at it, and I belive I can get it working, I will send in another diff for you to try.

Changed 16 years ago by simmel@…

comment:6 in reply to:  4 ; Changed 16 years ago by simmel@…

Try that akira. It works for me(TM).

comment:7 in reply to:  6 ; Changed 16 years ago by openspecies@…

Replying to simmel@soy.se:

Try that akira. It works for me(TM).

Hi Akira, patch the include in proctools.h (kvm.h remove it) and

#define USE_SYSCTL

a nicer way is:

#ifdef __APPLE__
#include AvailabilityMacros.h

Cheers!

Changed 16 years ago by openspecies@…

Attachment: compile-leopard.patch added

comment:8 in reply to:  7 ; Changed 16 years ago by simmel@…

Replying to openspecies@gmail.com:

Replying to simmel@soy.se:

Try that akira. It works for me(TM).

Hi Akira, patch the include in proctools.h (kvm.h remove it) and

#define USE_SYSCTL

a nicer way is:

#ifdef __APPLE__
#include AvailabilityMacros.h

Cheers!

Cool, much better patch than mine. To take it one step further, make -lkvm depend on USE_KVM too, but maybe that's not possible/very hard?

Anyway, good work!

comment:9 in reply to:  8 ; Changed 16 years ago by openspecies@…

Replying to simmel@soy.se:

Replying to openspecies@gmail.com:

Replying to simmel@soy.se:

Try that akira. It works for me(TM).

Hi Akira, patch the include in proctools.h (kvm.h remove it) and

#define USE_SYSCTL

a nicer way is:

#ifdef __APPLE__
#include AvailabilityMacros.h

Cheers!

Cool, much better patch than mine. To take it one step further, make -lkvm depend on USE_KVM too, but maybe that's not possible/very hard?

Anyway, good work!

yep I think that's possible, I only digg few minutes into proctools src, there are also some deprecated warnings from bsd.make, it's only a quick patch, anyway, it's perfectible using APPLE macro and the OS Version, no matter, :) THX

comment:10 in reply to:  9 Changed 16 years ago by openspecies@…

Replying to openspecies@gmail.com:

Replying to simmel@soy.se:

Replying to openspecies@gmail.com:

Replying to simmel@soy.se:

Try that akira. It works for me(TM).

Hi Akira, patch the include in proctools.h (kvm.h remove it) and

#define USE_SYSCTL

a nicer way is:

#ifdef __APPLE__
#include AvailabilityMacros.h

Cheers!

Cool, much better patch than mine. To take it one step further, make -lkvm depend on USE_KVM too, but maybe that's not possible/very hard?

Anyway, good work!

yep I think that's possible, I only digg few minutes into proctools src, there are also some deprecated warnings from bsd.make, it's only a quick patch, anyway, it's perfectible using APPLE macro and the OS Version, no matter, :) THX

My last comment: proctools need a src maintainer, a request to the author should be the right answer.

Cheers!

comment:11 Changed 16 years ago by akira@…

Thanks guys! I'll look into this.

comment:12 Changed 16 years ago by akira@…

Resolution: fixed
Status: assignedclosed

Committed in r36179. Thanks your the contribution! BTW, It would be nice to send these patches to upstream.

comment:13 Changed 16 years ago by bill.mill@…

r36179 has nothing to do with this bug. I successfully compiled .4pre1 after I applied compile-leopard.patch, but the MacPorts installation still fails for me with the error in the initial report.

comment:14 Changed 16 years ago by bill.mill@…

Resolution: fixed
Status: closedreopened

comment:15 in reply to:  14 Changed 16 years ago by bill.mill@…

Replying to bill.mill@gmail.com:

(errm, sorry, clean/selfupdate/install cycle and it worked like a charm. r36179 still has nothing to do with this bug though. Really sorry.)

comment:16 Changed 16 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: reopenedclosed

r37444 is what really fixed this.

comment:17 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.