New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #15420 (closed enhancement: fixed)

Opened 4 years ago

Last modified 16 months ago

pdftk: add newer gcc variant

Reported by: jochen@… Owned by: ryandesign@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: avs@…, freeed@…, jamal@…, thomas.lohschmidt@…, twalpole@…, massimo.bernaschi@…, zahanm@…, Markus.Ueberall@…, matteo.corti@…, electronjunction-misc@…, lopusz@…, henx@…, jjstickel@…, pinny@…, joefitz@…, jklymak@…
Port: pdftk

Description

Please add a gcc43 variant as in the attached patch

Attachments

pdftk.diff Download (1.9 KB) - added by jochen@… 4 years ago.
Portfile patch
osx-gcc45.patch Download (10.8 KB) - added by pinny@… 17 months ago.
diff for 10.6.4 using gcc45

Change History

Changed 4 years ago by jochen@…

Portfile patch

  Changed 4 years ago by ryandesign@…

  • status changed from new to assigned

I already did this locally but didn't commit it yet. The problem was that gcc43 doesn't supply gcj, and thus doesn't support building pdftk, on Mac OS X 10.4. gcc42, meanwhile, doesn't supply gcj, and thus doesn't support building pdftk, on Mac OS X 10.5 PowerPC (#13553). I guess I'll add the gcc43 variant to pdftk, and make it the default on Leopard, and keep gcc42 the default on Tiger and earlier.

  Changed 4 years ago by raimue@…

gcc43 provides gcj-mp-4.3, gcc42 provides gcj-mp-4.2. What is the problem?

  Changed 4 years ago by ryandesign@…

The problem is that gcc43 does not provide gcj-mp-4.3 on Mac OS X 10.5 PowerPC and gcc42 does not provide gcj-mp-4.2 on Mac OS X 10.4.

  Changed 4 years ago by ryandesign@…

Gah, other way around. gcc43 does not provide gcj-mp-4.3 on Mac OS X 10.4 (see the platform darwin 8 section of the gcc43 portfile and the comment "Java support does not compile on 10.4"), and gcc42 does not provide gcj-mp-4.2 on Mac OS X 10.5 PowerPC (see #13553).

  Changed 4 years ago by raimue@…

Okay, sorry for the noise, I did not know there were platform specific restrictions (should have followed that ticket link earlier...).

  Changed 3 years ago by ryandesign@…

  • port set to pdftk

Here is the current situation with pdftk +gcc43 when using the gcc 4.3.2_0 port:

  • 10.4 Intel:
    • gcc43 does not provide gcj-mp-4.3 because it does not compile; see #16409
  • 10.4 PowerPC:
  • 10.5 Intel:
  • 10.5 PowerPC:
    • gcj-mp-4.3: error trying to exec 'ecj1': execvp: No such file or directory

Even if gcc43 or another port provided ecj1, I've read that pdftk still won't compile with it. See this  gcc bug report and this  message on the gcc java mailing list, which were brought to my attention via #16440. Apparently pdftk is programmed incorrectly, and gcc42 and earlier compiled it successfully only by coincidence. gcc43 now considers this programming method a fatal error so we cannot add gcc43 support to the pdftk port until the developers of pdftk fix their code.

  Changed 3 years ago by bcbarnes@…

Any news on this? pdftk is available on linux distros which ship gcc43 by default. It would be nice to have on 10.5/Intel. thanks!

follow-up: ↓ 10   Changed 3 years ago by ryandesign@…

Nothing has changed, that I know of. I see no new release of pdftk since 1.41 on November 28, 2006, so I assume their code is still incompatible with anything greater than gcc42. I do not use any package manager other than MacPorts. If you know of another package manager, such as one in a Linux distribution, which is able to build pdftk with gcc43 or greater, and you can send me the patches they are using, please do so. Or if you would like to discuss the issue with the developers of pdftk and get them to provide a solution upstream, please do that; I have not done so.

  Changed 3 years ago by anonymous

  • milestone Port Enhancements deleted

Milestone Port Enhancements deleted

in reply to: ↑ 8 ; follow-ups: ↓ 12 ↓ 13   Changed 2 years ago by avs@…

Replying to ryandesign@…:

If you know of another package manager, such as one in a Linux distribution, which is able to build pdftk with gcc43 or greater, and you can send me the patches they are using, please do so.

Here's a related Gentoo bug that has a pdftk patch for gcc43, if it's of any value:  http://bugs.gentoo.org/show_bug.cgi?id=251796

  Changed 2 years ago by avs@…

  • cc avs@… added

Cc Me!

in reply to: ↑ 10   Changed 2 years ago by ryandesign@…

Replying to avs@…:

pdftk patch for gcc43

Thank you very much, I'll take a look at that.

in reply to: ↑ 10   Changed 2 years ago by avs@…

Replying to avs@…:

Here's a related Gentoo bug that has a pdftk patch for gcc43, if it's of any value:  http://bugs.gentoo.org/show_bug.cgi?id=251796

In addition, also Gentoo bugs  #225709 and  #235645, and  #269312 seem to have related patches. It seems those would bring it to gcc44.

  Changed 2 years ago by ryandesign@…

I have now had a chance to look at these Gentoo tickets.

  •  #251796 has a patch for various issues which purport to allow pdftk to compile with gcc43.
  •  #225709 says it was fixed by the patch from  #251796.
  •  #235645 is closed as a duplicate of  #225709.
  •  #269312 has a patch for one small issue which supposedly lets it compile with gcc44.

I am unable to test these patches however because gcc43, gcc44 and gcc45 in MacPorts don't appear to provide a working gcj. I filed #22065 and #22066 for these problems.

  Changed 2 years ago by freeed@…

  • cc freeed@… added

Cc Me!

  Changed 2 years ago by jamal@…

  • cc jamal@… added

Cc Me!

  Changed 2 years ago by thomas.lohschmidt@…

  • cc thomas.lohschmidt@… added

Cc Me!

  Changed 2 years ago by twalpole@…

  • cc twalpole@… added

Cc Me!

in reply to: ↑ description   Changed 2 years ago by massimo.bernaschi@…

Replying to jochen@…: Cc Me!

  Changed 2 years ago by massimo.bernaschi@…

  • cc massimo.bernaschi@… added

Cc Me!

  Changed 2 years ago by zahanm@…

  • cc zahanm@… added

Cc Me!

  Changed 2 years ago by jsnuverink@…

Cc Me!

  Changed 23 months ago by Markus.Ueberall@…

  • cc Markus.Ueberall@… added

Cc Me!

  Changed 22 months ago by matteo.corti@…

  • cc matteo.corti@… added

Cc Me!

  Changed 21 months ago by electronjunction-misc@…

  • cc electronjunction-misc@… added

Cc Me!

  Changed 21 months ago by lopusz@…

  • cc lopusz@… added

Cc Me!

  Changed 18 months ago by henx@…

  • cc henx@… added

Cc Me!

  Changed 18 months ago by jjstickel@…

  • cc jjstickel@… added

Cc Me!

  Changed 17 months ago by pinny@…

gcc45 in macports seems to work fine for me in 10.6.4. I had to patch the makefiles somewhat differently than in Gentoo (couldn't get objcopy working for osx, so I used nmedit instead), and I had to change the libiconv link directory for the final output, but the outputted pdftk is working!

  Changed 17 months ago by ryandesign@…

Can you provide the patches you used to make this work?

  Changed 17 months ago by ryandesign@…

  • cc pinny@… added

pinny, please see my comment above.

  Changed 17 months ago by joefitz@…

  • cc joefitz@… added

Cc Me!

Changed 17 months ago by pinny@…

diff for 10.6.4 using gcc45

  Changed 17 months ago by pinny@…

There was an issue getting the build past a certain point (perhaps caused by circular dependency between text.a and pdf.a?), but regenerating the .class files for text.a seemed to fix it. I'm not sure how to keep the .class files intact to compile it in one pass.

  Changed 17 months ago by jklymak@…

  • cc jklymak@… added

Cc Me!

  Changed 16 months ago by ryandesign@…

  • status changed from assigned to closed
  • resolution set to fixed
  • summary changed from RFE: add gcc43 variant for pdftk to pdftk: add newer gcc variant

In r72412 pdftk has been updated to version 1.43 and a gcc45 variant has been added. I have tested that pdftk 1.43 compiles fine with gcc45 on Snow Leopard and with gcc42 on Tiger. I did not test other gcc/OS version combinations.

gcc43 and gcc44 variants are not added because of #22066.

Note: See TracTickets for help on using tickets.