Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #15860 (closed enhancement: fixed)

Opened 5 months ago

Last modified 5 months ago

umit

Reported by: luis.kop@… Owned by: raimue@…
Priority: Normal Milestone: Port Requests
Component: ports Version: 1.6.0
Keywords: Cc: luis.kop@…
Port:

Description

Hi all.

I'm developer of Umit Project and i'm here to request that you test and give suggestions to fix and add our Portfile to our servers, if is it possible.

I hope your feedback.

Thanks for all.

Attachments

patch-setup.diff (0.6 KB) - added by luis.kop@… 5 months ago.
Portfile (0.7 KB) - added by luis.kop@… 5 months ago.
patch-base.diff (4.5 KB) - added by luis.kop@… 5 months ago.

Change History

Changed 5 months ago by luis.kop@…

  Changed 5 months ago by luis.kop@…

  • cc luis.kop@… added

Cc Me!

follow-up: ↓ 3   Changed 5 months ago by raimue@…

patch-base.diff hardcodes the prefix /opt/local into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace.

You already added a reinplace for ${prefix} in post-destroot {}, but I think it would be more appropriate to do this in post-patch {}.

in reply to: ↑ 2   Changed 5 months ago by luis.kop@…

Replying to raimue@macports.org:

patch-base.diff hardcodes the prefix /opt/local into the software. It should use ${prefix} instead, so it can be used in different places. I suggest to use a reinplace. You already added a reinplace for ${prefix} in post-destroot {}, but I think it would be more appropriate to do this in post-patch {}.

Hi. Thanks for the comment. About the patch-base it's true, it's hardcode. But how hack the file during the installation. Using sed?

About replace post-destroot by post-patch it's not a good idea. It didn't work. Is it mandatory in post-patch?

  Changed 5 months ago by raimue@…

Use this in the patch file:

CONFIG_DIR = "__PREFIX__/share/umit/config"
...

And use this post-patch:

post-patch {
    reinplace "s|__PREFIX__|${prefix}|g" ${worksrcpath}/umitCore/BasePaths.py
}

I don't think you need another reinplace in post-destroot.

Changed 5 months ago by luis.kop@…

Changed 5 months ago by luis.kop@…

  Changed 5 months ago by luis.kop@…

yeah. It's true.

You're right. I copy this from other Portfile and I didn't understand. Now I understand and I fix it. The files are commited. What do you think about that? Is it ok, now? :)

  Changed 5 months ago by raimue@…

  • owner changed from macports-tickets@… to raimue@…
  • status changed from new to assigned

  Changed 5 months ago by raimue@…

  • status changed from assigned to closed
  • resolution set to fixed

Committed in r38112.

Note: See TracTickets for help on using tickets.