New Ticket     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #17606 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Default variant of vim doesn't build due to X11 dependency

Reported by: pgijnxn02@… Owned by: raimue@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Xsetlocale X11 Cc: messi@…, blb@…
Port: vim

Description (last modified by ryandesign@…) (diff)

I failed to build vim with no variants.

The configure log shows --enable-gui=no --without-x but the linker fails with this message: 

/usr/libexec/gcc/powerpc-apple-darwin8/4.0.1/ld: Undefined symbols:
 __Xsetlocale

Adding -lX11 to the linker command line enabled it to build and I was able to continue.

Attachments

config.log Download (196.9 KB) - added by pgijnxn02@… 3 years ago.
patch-src_auto_configure.diff Download (484 bytes) - added by blb@… 3 years ago.
diff to src/auto/configure

Change History

Changed 3 years ago by pgijnxn02@…

in reply to: ↑ description   Changed 3 years ago by pgijnxn02@…

My setup:

Macports Trunk vim @7.2.065_0 OS X Tiger 10.4.11 Mac Mini PPC

  Changed 3 years ago by jmr@…

  • owner changed from macports-tickets@… to raimue@…

  Changed 3 years ago by macsforever2000@…

  • keywords vim removed
  • port changed from editors/vim to vim

  Changed 3 years ago by ryandesign@…

  • description modified (diff)

follow-up: ↓ 6   Changed 3 years ago by messi@…

This problem comes with --enable-multibyte. Replacing it with --disable-multibyte also fixes the problem. No libX11 needed.

Vim feature +multi_byte is activated again if i.e. variant +huge is specified.

in reply to: ↑ 5 ; follow-up: ↓ 7   Changed 3 years ago by raimue@…

Replying to messi@…:

This problem comes with --enable-multibyte. Replacing it with --disable-multibyte also fixes the problem. No libX11 needed.

Thanks for tracking this down. Strange enough that multibyte support needs X. How should I change this? Should I move multibyte in its own variant, as it was until some time ago?

in reply to: ↑ 6   Changed 3 years ago by messi@…

Replying to raimue@…:

Replying to messi@…:

This problem comes with --enable-multibyte. Replacing it with --disable-multibyte also fixes the problem. No libX11 needed.

Thanks for tracking this down. Strange enough that multibyte support needs X. How should I change this? Should I move multibyte in its own variant, as it was until some time ago?

Good question. I think you should take a look at ./src/auto/configure:15458 first. When you allow --enable-multibyte to be set (globally or by variant) you should make sure that $x_includes is empty if X11 is not installed. Otherwise configure tries to link the check program against libX11.

  Changed 3 years ago by messi@…

  • cc messi@… added

Cc Me!

Changed 3 years ago by blb@…

diff to src/auto/configure

  Changed 3 years ago by blb@…

  • cc blb@… added

Adding this patch to the port should get it to work properly; a similar one against src/configure.in should probably be sent upstream.

  Changed 3 years ago by raimue@…

  • status changed from new to assigned

I applied the patch to both vim and vim-app in r45697. I will look into sending a patch against configure.in to upstream.

  Changed 3 years ago by anonymous

  • milestone Port Bugs deleted

Milestone Port Bugs deleted

  Changed 3 years ago by raimue@…

  • status changed from assigned to closed
  • resolution set to fixed

The patch has been accepted upstream as 7.2.159.

Note: See TracTickets for help on using tickets.