New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #18119 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

dcmtk - 3.5.4 - Version is not most recent and contains critical bugs

Reported by: krunk7@… Owned by: guidolorenz@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc:
Port: dcmtk

Description

The version of dcmtk installed by macports is not the most recent patch level (p2). Some of the bugs fixed by this patch include one that fixes a broken findscu when the option key=value format is used.

Patched files are found here: ftp://dicom.offis.de/pub/dicom/offis/software/dcmtk/dcmtk354/patch/dcmtk-3.5.4_p2.tar.gz

Attachments

patch-dcmnet-apps-findscu.cc.diff (4.0 KB) - added by guidolorenz@… 4 years ago.
patch-dcmnet-apps-movescu.cc.diff (3.9 KB) - added by guidolorenz@… 4 years ago.
Portfile.diff (2.0 KB) - added by guidolorenz@… 4 years ago.

Change History

comment:1 Changed 4 years ago by macsforever2000@…

  • Owner changed from macports-tickets@… to guidolorenz@…
  • Port set to dcmtk

Changed 4 years ago by guidolorenz@…

Changed 4 years ago by guidolorenz@…

Changed 4 years ago by guidolorenz@…

comment:2 Changed 4 years ago by guidolorenz@…

The patch contains two replacement source files. I created two patchfiles that apply the changes and updated the Portfile accordingly.

I'm not sure if this is "the good way" to do it, so I'm open to suggestions. Otherwise, it would be nice if someone could commit the files, since I'm not a committer.

comment:3 Changed 4 years ago by krunk7@…

That sounds solid to me. I had written a local port that fetched the "patched" files then copied them over during the unpack phase. The end result is what counts though. :)

comment:4 Changed 4 years ago by macsforever2000@…

  • Status changed from new to closed
  • Resolution set to fixed

Committed revision r45760. Thanks! Note that this port could be improved by using a variable calculated from the $version instead of hardcoding the version as "354" in a number of places.

comment:5 Changed 4 years ago by anonymous

  • Milestone Port Bugs deleted

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.