#18119 closed defect (fixed)
dcmtk - 3.5.4 - Version is not most recent and contains critical bugs
| Reported by: | krunk7@… | Owned by: | guidolorenz@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.0 |
| Keywords: | Cc: | ||
| Port: | dcmtk |
Description
The version of dcmtk installed by macports is not the most recent patch level (p2). Some of the bugs fixed by this patch include one that fixes a broken findscu when the option key=value format is used.
Patched files are found here: ftp://dicom.offis.de/pub/dicom/offis/software/dcmtk/dcmtk354/patch/dcmtk-3.5.4_p2.tar.gz
Attachments (3)
Change History (8)
comment:1 Changed 15 years ago by mf2k (Frank Schima)
| Owner: | changed from macports-tickets@… to guidolorenz@… |
|---|---|
| Port: | dcmtk added |
Changed 15 years ago by guidolorenz@…
| Attachment: | patch-dcmnet-apps-findscu.cc.diff added |
|---|
Changed 15 years ago by guidolorenz@…
| Attachment: | patch-dcmnet-apps-movescu.cc.diff added |
|---|
Changed 15 years ago by guidolorenz@…
| Attachment: | Portfile.diff added |
|---|
comment:2 Changed 15 years ago by guidolorenz@…
comment:3 Changed 15 years ago by krunk7@…
That sounds solid to me. I had written a local port that fetched the "patched" files then copied them over during the unpack phase. The end result is what counts though. :)
comment:4 Changed 15 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed revision r45760. Thanks! Note that this port could be improved by using a variable calculated from the $version instead of hardcoding the version as "354" in a number of places.
Note: See
TracTickets for help on using
tickets.
The patch contains two replacement source files. I created two patchfiles that apply the changes and updated the Portfile accordingly.
I'm not sure if this is "the good way" to do it, so I'm open to suggestions. Otherwise, it would be nice if someone could commit the files, since I'm not a committer.