New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #18314 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

ruby19 nosuffix variant

Reported by: jonbrenner@… Owned by: febeling@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: ruby19 suffix Cc:
Port: ruby19

Description

The attached patch adds a "nosuffix" variant which removes the --program-suffix=1.9 configure arg.

Attachments

Portfile-ruby19.diff (460 bytes) - added by jonbrenner@… 5 years ago.

Change History

Changed 5 years ago by jonbrenner@…

comment:1 Changed 5 years ago by jmr@…

  • Owner changed from macports-tickets@… to febeling@…

comment:2 Changed 5 years ago by febeling@…

There are 2 reasons why I'm not so fond of that idea:

  • It would conflict with ruby 1.8 port
  • As things are, the variant would be lost with the next update, and that would mean the names of executables change with an upgrade.

Are there strong reasons to add this still?

comment:3 follow-up: ↓ 5 Changed 5 years ago by jmr@…

Why would the variant be lost with the next update? The only known problem with the wrong variants being selected on upgrade is that default variants become re-selected if you had them deselected.

comment:4 follow-up: ↓ 6 Changed 5 years ago by jonbrenner@…

Copied from the mailing list:

I used a "conflicts ruby" directive to prevent problems when the 1.8 port is active on a system. Would that work? I'm new to macports and wasn't sure whether the directive signals conflicts with other ports or just variants.

Why would the variant get lost with the next update?

As for the reason behind it, I am running 1.9 exclusively and prefer to have no program suffix. I thought the variant was a clean and appropriate way to accomplish that without managing symlinks to each binary distributed with the package (ruby, rdoc, rake, gem, ri, etc.).

comment:5 in reply to: ↑ 3 Changed 5 years ago by febeling@…

Replying to jmr@…:

Why would the variant be lost with the next update? The only known problem with the wrong variants being selected on upgrade is that default variants become re-selected if you had them deselected.

If that is the case then I had a misconception here. Thanks for pointing out. That changes the picture a bit for this request.

comment:6 in reply to: ↑ 4 Changed 5 years ago by febeling@…

Replying to jonbrenner@…:

Copied from the mailing list:

I used a "conflicts ruby" directive to prevent problems when the 1.8 port is active on a system. Would that work? I'm new to macports and wasn't sure whether the directive signals conflicts with other ports or just variants.

nah, conflicts deals with other variants, not with ports.

Why would the variant get lost with the next update?

See Joshua's comment above. There is a bug with variants being dropped, but as Joshua points out above it is only under certain conditions, which I wasn't aware of. So I will have a fresh look at this tomorrow. Thanks for putting together and submitting a patch, btw!

comment:7 Changed 5 years ago by febeling@…

  • Status changed from new to closed
  • Resolution set to fixed

comment:8 Changed 5 years ago by anonymous

  • Milestone Port Enhancements deleted

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.