Opened 20 years ago

Closed 20 years ago

Last modified 15 years ago

#1838 closed defect (fixed)

Gimp 2.0.1 Build Fails due to stray newline

Reported by: devin@… Owned by: tobypeterson
Priority: Normal Milestone:
Component: ports Version: 1.0
Keywords: Cc:
Port:

Description

From Eric.Kort at vai.org Mon May 3 16:00:04 2004 From: Eric.Kort at vai.org (Kort, Eric) Date: Mon May 3 16:00:11 2004 Subject: [darwinports-bugs] Gimp 2.0.1 Build Fails due to stray newline Message-ID: <74D0F0AB07F2E647A02D839ED79520F92088E1@…>

Hello.

FYI: When building Gimp 2.0.1 with darwinports, I encountered the following error (fix follows):

source='gimpdnd.c' object='gimpdnd.o' libtool=no \ depfile='.deps/gimpdnd.Po' tmpdepfile='.deps/gimpdnd.TPo' \ depmode=gcc /bin/sh ../../depcomp \ gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../.. -I../../app -I../../app -DXTHREADS -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/atk-1.0 -I/opt/local/include/pango-1.0 -I/opt/local/include -I/opt/local/include/freetype2 -I/usr/X11R6/include -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/pango-1.0 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -DG_LOG_DOMAIN=\"Gimp-Widgets\" -D_REENTRANT -I/opt/local/include -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE -g -O2 -Wall -c `test -f 'gimpdnd.c'

echo './'`gimpdnd.c

gimpdnd.c:812: warning: #warning FIXME: missing GTK+ dnd API gimpdnd.c:857: warning: #warning FIXME: missing GTK+ dnd API gimpdnd.c:1212: stray '\' in program gimpdnd.c:1212: stray '\' in program gimpdnd.c:1212: stray '\' in program gimpdnd.c:1212: warning: ANSI C forbids newline in string constant gimpdnd.c:1216: warning: ANSI C forbids newline in string constant gimpdnd.c:1212: unterminated macro invocation gimpdnd.c:2267: illegal compound statement: encountered end of stream cpp-precomp: warning: errors during smart preprocessing, retrying in basic mode make: * [gimpdnd.o] Error 1

The following fix to gimp2/work/gimp-2.0.1/apps/widgets/gimpdnd.c resolved the error:

  • D (g_print ("gimp_dnd_open_files: trying to convert "
  • \"%s\" to an uri.\n", dnd_crap));

+ D (g_print ("gimp_dnd_open_files: trying to convert \"%s\" to an uri.\n", dnd_crap));

Thanks, Eric

Attachments (2)

gimp2.diff (989 bytes) - added by devin@… 20 years ago.
Proper patch for Fix
gimp2.2.diff (900 bytes) - added by devin@… 20 years ago.
Patch that works

Download all attachments as: .zip

Change History (7)

Changed 20 years ago by devin@…

Attachment: gimp2.diff added

Proper patch for Fix

comment:1 Changed 20 years ago by devin@…

I just wanted to say that this bug report was created because I tried searching darwinport's bugzilla on this problem and came up with nothing. However searching google gave me a text archive of darwinports-bugs mailing list that had that message. I posted this bug so others can search bugzilla like me. And so the fix could be incorporated into CVS after approval of the maintainer. Since the email didn't offer a darwinsport patch but a patch to fix as you go. I made one for inclusion to CVS.

If this is improper use of bugzilla pleased inform me.

Changed 20 years ago by devin@…

Attachment: gimp2.2.diff added

Patch that works

comment:2 Changed 20 years ago by devin@…

attachments.isobsolete: 01

comment:3 Changed 20 years ago by olegb@…

Owner: changed from darwinports-bugs@… to toby@…

assigning to maintainer

comment:4 Changed 20 years ago by toby@…

Resolution: fixed
Status: newclosed

still occur with gimp 2.0.5? I've never, ever been able to reproduce this problem.

comment:5 Changed 20 years ago by devin@…

I have since rebuilt my machine to 10.3 I have no idea if it is a problem or not. And I'm not able to test it anymore. Perhas someone on the mailinglist can add some light.

Note: See TracTickets for help on using tickets.