#18802 closed enhancement (fixed)
RFE: build libpng with PortGroup muniversal
| Reported by: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.7.0 |
| Keywords: | universal | Cc: | waqar@… |
| Port: | libpng |
Description
Attached is a proposed change to libpng.
I can find no errors, but it seems to me that muniversal is the safer choice
for the long term.
It also test all architectures it can.
Attachments (1)
Change History (6)
Changed 15 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 15 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
comment:2 follow-up: 3 Changed 15 years ago by raimue (Rainer Müller)
Replying to mcalhoun@…:
I can find no errors, but it seems to me that muniversal is the safer choice
for the long term.
No, for long term this should be fixed in base, not with a wild hack in a port group. :-)
comment:3 Changed 15 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Replying to raimue@…:
Replying to mcalhoun@…:
I can find no errors, but it seems to me that muniversal is the safer choice
for the long term.No, for long term this should be fixed in base, not with a wild hack in a port group. :-)
Point taken.
Perhaps a better phrasing would be:
The stratagem implemented in the muniversal PortGroup and more correctly included in the base is a safer choice for the long term.
comment:4 Changed 15 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in r49129 (maintainer timeout).
comment:5 Changed 15 years ago by (none)
| Milestone: | Port Enhancements |
|---|
Milestone Port Enhancements deleted
In the tests I was doing, I removed ranlib.
It should probably not be included in this patch, but I do not think is necessary anymore (it was added in r5379).