New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #20486 (closed update: fixed)

Opened 4 years ago

Last modified 3 years ago

update emacs to 23.1, remove carbon/cocoa bits

Reported by: brett@… Owned by: darren.bane@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryan_ware@…, docwhat@…, tonytung@…, hong.rich@…, macports@…, mcamou@…, pff@…, jdfrens@…, chalin@…, luis.beca@…, ronhuang@…, miqqis@…, bob.spamnot@…, jsg8pitt@…, snc@…, dports@…
Port: emacs

Description

The carbon port is dead, long live --with-ns

Attachments

emacs-cocoa.diff (2.3 KB) - added by toby@… 4 years ago.
Portfile (2.4 KB) - added by bob.spamnot@… 4 years ago.
emacs.diff (2.5 KB) - added by snc@… 4 years ago.
diff with bob's portfile

Change History

Changed 4 years ago by toby@…

comment:1 follow-up: ↓ 2 Changed 4 years ago by toby@…

Added a patch that makes it sort of compile, albeit with tons of warnings. Their so-called Cocoa port is about as awful as I would've expected. :)

comment:2 in reply to: ↑ 1 Changed 4 years ago by bob.spamnot@…

I would recommend keeping the X11 variants (X11 and gtk, especially) separate from the cocoa version, as in is now. The cocoa version would be in emacs-app. This is due to the fact that they are quite different in where they get installed. Furthermore, the X11 variants work very well and the cocoa version is still work in progress and has problems.

The carbon version is gone and should be removed from the 23.1 port.

comment:3 Changed 4 years ago by blb@…

  • Cc ryan_ware@… added

Cc reporter of dup #20745.

comment:4 Changed 4 years ago by bob.spamnot@…

Why the delay on this upgrade? It should be straightforward. I've enclosed a Portfile which I think should work. It eliminates all mention of carbon, has no emacs-app as that is in a separate port (which I see is already upgraded to 23.1) and updates the md5. I don't think any patchfiles are needed and the --without-x is changed to --with-x-toolkit=no.

Give it a try (on Leopard, as I've heard emacs won't compile on SL but that's a separate issue).

Changed 4 years ago by bob.spamnot@…

comment:5 Changed 4 years ago by toby@…

I think the approach of removing carbon & cocoa is good - we have emacs-app for that. I'm guessing the maintainer is AWOL - Darren?

comment:6 Changed 4 years ago by toby@…

  • Summary changed from update emacs to 23.1 and change carbon port to cocoa to update emacs to 23.1, remove carbon/cocoa bits

comment:7 Changed 4 years ago by toby@…

  • Cc docwhat@…, tonytung@…, hong.rich@…, macports@…, mcamou@…, pff@…, jdfrens@…, chalin@… added
  • Version 1.7.1 deleted

comment:8 Changed 4 years ago by luis.beca@…

  • Cc luis.beca@… added

Cc Me!

comment:9 follow-up: ↓ 12 Changed 4 years ago by snc@…

If I'm reading bob's portfile correctly, we're removing the --without-carbon arg. Is that right?

Changed 4 years ago by snc@…

diff with bob's portfile

comment:10 Changed 4 years ago by ronhuang@…

  • Cc ronhuang@… added

Cc Me!

comment:11 Changed 4 years ago by miqqis@…

  • Cc miqqis@… added

Cc Me!

comment:12 in reply to: ↑ 9 Changed 4 years ago by bob.spamnot@…

Replying to snc@…:

If I'm reading bob's portfile correctly, we're removing the --without-carbon arg. Is that right?

Yes, --without-carbon is not needed with the 23.1 build system since it defaults to X11 first. I suppose it would not hurt anything.

comment:13 Changed 4 years ago by bob.spamnot@…

  • Cc bob.spamnot@… added

Cc Me!

comment:14 Changed 4 years ago by jsg8pitt@…

  • Cc jsg8pitt@… added

Cc Me!

comment:15 Changed 4 years ago by snc@…

  • Cc snc@… added

Cc Me!

comment:16 Changed 4 years ago by dports@…

  • Cc dports@… added

Cc Me!

comment:17 Changed 3 years ago by blair@…

Fixed in r62682. See #23165 for more information.

comment:18 Changed 3 years ago by blair@…

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.